MC-33400: [Improvement] Magento\Checkout\Model\Cart::addOrderItem

Author: RuslanKostiv1

app/code/Magento/Sales/Model/Reorder/Reorder.php

@@ -183,17 +183,7 @@ private function addItemsToCart(Quote $cart, ItemCollection $orderItems, string
             }
         }
 
-        /** @var Collection $collection */
-        $collection = $this->productCollectionFactory->create();
-
-        $collection->setStore($storeId);
-        $collection->addIdFilter($orderItemProductIds);
-        $collection->addStoreFilter();
-        $collection->addAttributeToSelect('*');
-        $collection->joinAttribute('status', 'catalog_product/status', 'entity_id', null, 'inner');
-        $collection->joinAttribute('visibility', 'catalog_product/visibility', 'entity_id', null, 'inner');
-
-        $products = $collection->getItems();
+        $products = $this->getOrderProducts($storeId, $orderItemProductIds);
 
         // compare founded products and throw an error if some product not exists
         $productsNotFound = array_diff($orderItemProductIds, array_keys($products));
@@ -218,6 +208,28 @@ private function addItemsToCart(Quote $cart, ItemCollection $orderItems, string
         }
     }
 
+    /**
+     * Get order products by store id and order item product ids.
+     *
+     * @param string $storeId
+     * @param int[] $orderItemProductIds
+     * @return Product[]
+     * @throws \Magento\Framework\Exception\LocalizedException
+     */
+    private function getOrderProducts(string $storeId, array $orderItemProductIds): array
+    {
+        /** @var Collection $collection */
+        $collection = $this->productCollectionFactory->create();
+        $collection->setStore($storeId)
+            ->addIdFilter($orderItemProductIds)
+            ->addStoreFilter()
+            ->addAttributeToSelect('*')
+            ->joinAttribute('status', 'catalog_product/status', 'entity_id', null, 'inner')
+            ->joinAttribute('visibility', 'catalog_product/visibility', 'entity_id', null, 'inner');
+
+        return $collection->getItems();
+    }
+
     /**
      * Adds order item product to cart.
      *