Skip to content

Commit e578286

Browse files
glo74186glo74186
committed
ACQE-3393 : Added meaningful stepkeys
1 parent a4bf464 commit e578286

File tree

2 files changed

+75
-71
lines changed

2 files changed

+75
-71
lines changed

‎app/code/Magento/Cms/Test/Mftf/Test/AdminConfigureStoreInformationTest.xml

Lines changed: 68 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<testCaseId value="AC-3963"/>
1818
</annotations>
1919
<before>
20-
<actionGroup ref="AdminLoginActionGroup" stepKey="loginGetFromGeneralFile"/>
20+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginToBackend"/>
2121
</before>
2222
<after>
2323
<actionGroup ref="AdminSetStoreInformationConfigurationActionGroup" stepKey="resetStoreInformationConfig">
@@ -34,76 +34,75 @@
3434
<actionGroup ref="DeletePageByUrlKeyActionGroup" stepKey="deletePage">
3535
<argument name="UrlKey" value="{{_defaultCmsPage.identifier}}"/>
3636
</actionGroup>
37-
<actionGroup ref="EuropeanCountriesOptionActionGroup" stepKey="checkConfig"/>
37+
<actionGroup ref="EuropeanCountriesSystemCheckBoxActionGroup" stepKey="checkSystemValueConfig"/>
3838
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3939
</after>
4040
<!--Set StoreInformation configs data-->
41-
<actionGroup ref="AdminSetStoreInformationConfigurationActionGroup" stepKey="setStoreInformationConfigData">
42-
<argument name="telephone" value="{{DE_Address_Berlin_Not_Default_Address.telephone}}"/>
43-
<argument name="country" value="{{DE_Address_Berlin_Not_Default_Address.country_id}}"/>
44-
<argument name="state" value="{{DE_Address_Berlin_Not_Default_Address.state}}"/>
45-
<argument name="city" value="{{DE_Address_Berlin_Not_Default_Address.city}}"/>
46-
<argument name="postcode" value="{{DE_Address_Berlin_Not_Default_Address.postcode}}"/>
47-
<argument name="street" value="{{DE_Address_Berlin_Not_Default_Address.street[0]}}"/>
48-
</actionGroup>
49-
<magentoCLI command="config:set {{SetEuropeanUnionCountries.path}} {{SetEuropeanUnionCountries.value}}" stepKey="selectEUCountries"/>
50-
<actionGroup ref="AdminOpenCMSPagesGridActionGroup" stepKey="navigateToCmsPageGrid"/>
51-
<click selector="{{CmsPagesPageActionsSection.addNewPageButton}}" stepKey="clickAddNewPage"/>
52-
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{_defaultCmsPage.title}}" stepKey="fillFieldTitle"/>
53-
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
54-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
55-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowToRootContainer">
56-
<argument name="contentType" value="PageBuilderRowContentType"/>
57-
<argument name="containerTargetType" value="PageBuilderRootContainerContentType"/>
58-
</actionGroup>
59-
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
60-
<argument name="contentType" value="PageBuilderTextContentType"/>
61-
</actionGroup>
62-
<actionGroup ref="dragContentTypeToStage" stepKey="dragIntoStage">
63-
<argument name="contentType" value="PageBuilderTextContentType"/>
64-
</actionGroup>
65-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
66-
<argument name="contentType" value="PageBuilderTextContentType"/>
67-
</actionGroup>
68-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableButton1"/>
69-
<wait time="2" stepKey="waitForLoadOne"/>
70-
<click selector="{{VariableSection.VariableRadio('General / Store Information / Store Name')}}" stepKey="selectDefaultVariable"/>
71-
<wait time="2" stepKey="waitForLoad121"/>
72-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableone"/>
73-
<wait time="2" stepKey="waitForLoadTwo"/>
74-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableButtonTwo"/>
75-
<wait time="2" stepKey="waitForLoadThree"/>
76-
<click selector="{{VariableSection.VariableRadio('General / Store Information / Street Address')}}" stepKey="selectDefaultVariable1"/>
77-
<wait time="2" stepKey="waitForLoadFour"/>
78-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableTwo"/>
79-
<wait time="2" stepKey="waitForLoadFive"/>
80-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainAgain"/>
81-
<wait time="2" stepKey="waitForLoadSix"/>
82-
<click selector="{{VariableSection.VariableRadio('General / Store Information / City')}}" stepKey="selectDefaultVariable2"/>
83-
<wait time="2" stepKey="waitForLoadSeaven"/>
84-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableThree"/>
85-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainAgain1"/>
86-
<wait time="2" stepKey="waitForLoadEight"/>
87-
<click selector="{{VariableSection.VariableRadio('General / Store Information / ZIP/Postal Code')}}" stepKey="selectDefaultVariable3"/>
88-
<wait time="2" stepKey="waitForLoadNine"/>
89-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableFour"/>
90-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainAgain2"/>
91-
<wait time="2" stepKey="waitForLoadTen"/>
92-
<click selector="{{VariableSection.VariableRadio('General / Store Information / Region/State')}}" stepKey="selectDefaultVariable4"/>
93-
<wait time="2" stepKey="waitForLoadEleaven"/>
94-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableFive"/>
95-
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainAgain9"/>
96-
<wait time="2" stepKey="waitForLoadTwelve"/>
97-
<click selector="{{VariableSection.VariableRadio('General / Store Information / Country')}}" stepKey="selectDefaultVariable5"/>
98-
<wait time="2" stepKey="waitForLoadThirteen"/>
99-
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableSix"/>
100-
<wait time="2" stepKey="waitForLoadFourteen"/>
101-
<click selector="{{TextOnConfiguration.savePage}}" stepKey="clickOnSave"/>
102-
<wait time="2" stepKey="waitForLoadFifteen"/>
103-
<click selector="{{TextOnConfiguration.arrowPage}}" stepKey="clickOnArrow"/>
104-
<click selector="{{CmsNewPagePageSeoSection.header}}" stepKey="clickExpandSearchEngineOptimisation"/>
105-
<fillField selector="{{CmsNewPagePageSeoSection.urlKey}}" userInput="{{_defaultCmsPage.identifier}}" stepKey="fillFieldUrlKey"/>
106-
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPageAgain"/>
107-
<amOnPage url="{{_defaultCmsPage.identifier}}" stepKey="amOnPageTestPageRefresh"/>
41+
<actionGroup ref="AdminSetStoreInformationConfigurationActionGroup" stepKey="setStoreInformationConfigData">
42+
<argument name="telephone" value="{{DE_Address_Berlin_Not_Default_Address.telephone}}"/>
43+
<argument name="country" value="{{DE_Address_Berlin_Not_Default_Address.country_id}}"/>
44+
<argument name="state" value="{{DE_Address_Berlin_Not_Default_Address.state}}"/>
45+
<argument name="city" value="{{DE_Address_Berlin_Not_Default_Address.city}}"/>
46+
<argument name="postcode" value="{{DE_Address_Berlin_Not_Default_Address.postcode}}"/>
47+
<argument name="street" value="{{DE_Address_Berlin_Not_Default_Address.street[0]}}"/>
48+
</actionGroup>
49+
<magentoCLI command="config:set {{SetEuropeanUnionCountries.path}} {{SetEuropeanUnionCountries.value}}" stepKey="selectEUCountries"/>
50+
<actionGroup ref="AdminOpenCMSPagesGridActionGroup" stepKey="navigateToCmsPageGrid"/>
51+
<click selector="{{CmsPagesPageActionsSection.addNewPageButton}}" stepKey="clickAddNewPage"/>
52+
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{_defaultCmsPage.title}}" stepKey="fillFieldTitle"/>
53+
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPage"/>
54+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
55+
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowToRootContainer">
56+
<argument name="contentType" value="PageBuilderRowContentType"/>
57+
<argument name="containerTargetType" value="PageBuilderRootContainerContentType"/>
58+
</actionGroup>
59+
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
60+
<argument name="contentType" value="PageBuilderTextContentType"/>
61+
</actionGroup>
62+
<actionGroup ref="dragContentTypeToStage" stepKey="dragIntoStage">
63+
<argument name="contentType" value="PageBuilderTextContentType"/>
64+
</actionGroup>
65+
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
66+
<argument name="contentType" value="PageBuilderTextContentType"/>
67+
</actionGroup>
68+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableButton"/>
69+
<wait time="2" stepKey="waitForPageToLoadForToInsertButtonForStoreName"/>
70+
<click selector="{{VariableSection.VariableRadio('General / Store Information / Store Name')}}" stepKey="selectDefaultVariable"/>
71+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableStoreName"/>
72+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableForStAds"/>
73+
<wait time="2" stepKey="waitForPageToLoadToSelectInsertVariableButtonForStAds"/>
74+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="againClickInsertVariableButtonForStAds"/>
75+
<wait time="2" stepKey="againWaitForPageToLoadToSelectInsertVariableButtonForStAds"/>
76+
<click selector="{{VariableSection.VariableRadio('General / Store Information / Street Address')}}" stepKey="selectDefaultVariableForStAds"/>
77+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableStAds"/>
78+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableForStore"/>
79+
<wait time="2" stepKey="waitForPageToLoadForToInsertButtonForStore"/>
80+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="againClickInsertVariableForStore"/>
81+
<wait time="2" stepKey="againWaitForPageToLoadToSelectInsertVariableButtonForStore"/>
82+
<click selector="{{VariableSection.VariableRadio('General / Store Information / City')}}" stepKey="selectDefaultVariableForStore"/>
83+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableStore"/>
84+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableForCode"/>
85+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainForCode"/>
86+
<wait time="2" stepKey="WaitForPageToLoadToSelectInsertVariableButtonForCode"/>
87+
<click selector="{{VariableSection.VariableRadio('General / Store Information / ZIP/Postal Code')}}" stepKey="selectDefaultVariableForCode"/>
88+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableCode"/>
89+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableForState"/>
90+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainForState"/>
91+
<wait time="2" stepKey="WaitForPageToLoadToSelectInsertVariableButtonForState"/>
92+
<click selector="{{VariableSection.VariableRadio('General / Store Information / Region/State')}}" stepKey="selectDefaultVariableForState"/>
93+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableForState"/>
94+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariableForCountry"/>
95+
<click selector="{{TextOnConfiguration.insertVariableButton}}" stepKey="clickInsertVariableAgainForCountry"/>
96+
<wait time="2" stepKey="WaitForPageToLoadToSelectInsertVariableButtonForCountry"/>
97+
<click selector="{{VariableSection.VariableRadio('General / Store Information / Country')}}" stepKey="selectDefaultVariableForCountry"/>
98+
<wait time="2" stepKey="waitForPageToLoadForToSelectDefaultVariableForCountry"/>
99+
<click selector="{{VariableSection.InsertWidget}}" stepKey="clickInsertVariable"/>
100+
<wait time="2" stepKey="waitForLoad"/>
101+
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings"/>
102+
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
103+
<click selector="{{CmsNewPagePageSeoSection.header}}" stepKey="clickExpandSearchEngineOptimisation"/>
104+
<fillField selector="{{CmsNewPagePageSeoSection.urlKey}}" userInput="{{_defaultCmsPage.identifier}}" stepKey="fillFieldUrlKey"/>
105+
<actionGroup ref="SaveAndContinueEditCmsPageActionGroup" stepKey="saveAndContinueEditCmsPageAgain"/>
106+
<amOnPage url="{{_defaultCmsPage.identifier}}" stepKey="amOnPageTestPageRefresh"/>
108107
</test>
109108
</tests>

‎app/code/Magento/Config/Test/Mftf/ActionGroup/EuropeanCountriesSystemCheckBoxActionGroup.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,17 @@
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11-
<actionGroup name="EuropeanCountriesOptionActionGroup" extends="EuropeanCountriesOptionActionGroup">
11+
<actionGroup name="EuropeanCountriesSystemCheckBoxActionGroup">
1212
<annotations>
1313
<description>check system value european country option value</description>
1414
</annotations>
1515

16-
<remove keyForRemoval="uncheckConfigSetting"/>
16+
<amOnPage url="{{AdminConfigGeneralPage.url}}" stepKey="navigateToAdminStoreConfiguration"/>
17+
<conditionalClick selector="{{CountriesFormSection.block}}" dependentSelector="{{CountriesFormSection.label}}" visible="false" stepKey="expand_panel"/>
18+
<scrollTo selector="{{CountriesFormSection.label}}" stepKey="scrollToLabel" />
19+
<wait time="2" stepKey="waitForLoad"/>
1720
<checkOption selector="{{CountriesFormSection.useConfigSettings}}" stepKey="checkConfigSetting"/>
21+
<wait time="2" stepKey="waitForPageLoad"/>
22+
<click selector="{{CountriesFormSection.saveConfig}}" stepKey="clickSave"/>
1823
</actionGroup>
1924
</actionGroups>

0 commit comments

Comments
 (0)