Add indexing after creating products + changes due to invalid use of sku as URL Key :-(

Author: lbajsarowicz

app/code/Magento/Catalog/Test/Mftf/Data/ProductData.xml

@@ -239,7 +239,7 @@
     </entity>
     <entity name="ApiSimpleOutOfStock" type="product2">
         <data key="name" unique="suffix">Api Simple Out Of Stock Product</data>
-        <data key="sku" unique="suffix">apisimpleproduct</data>
+        <data key="sku" unique="suffix">api-simple-product</data>
         <data key="urlKey" unique="suffix">api-simple-product</data>
         <data key="type_id">simple</data>
         <data key="attribute_set_id">4</data>
@@ -251,7 +251,7 @@
     </entity>
     <entity name="ApiSimpleOne" type="product2">
         <data key="name" unique="suffix">Api Simple Product</data>
-        <data key="sku" unique="suffix">apisimpleproduct</data>
+        <data key="sku" unique="suffix">api-simple-product</data>
         <data key="urlKey" unique="suffix">api-simple-product</data>
         <data key="type_id">simple</data>
         <data key="attribute_set_id">4</data>
@@ -267,7 +267,7 @@
     </entity>
     <entity name="ApiSimpleOneHidden" type="product2">
         <data key="name" unique="suffix">Api Simple Product</data>
-        <data key="sku" unique="suffix">apisimpleproduct</data>
+        <data key="sku" unique="suffix">api-simple-product</data>
         <data key="urlKey" unique="suffix">api-simple-product</data>
         <data key="type_id">simple</data>
         <data key="attribute_set_id">4</data>
@@ -280,7 +280,7 @@
     </entity>
     <entity name="ApiSimpleTwo" type="product2">
         <data key="name" unique="suffix">Api Simple Product Two</data>
-        <data key="sku" unique="suffix">apisimpleproducttwo</data>
+        <data key="sku" unique="suffix">api-simple-product-two</data>
         <data key="urlKey" unique="suffix">api-simple-product-two</data>
         <data key="type_id">simple</data>
         <data key="attribute_set_id">4</data>

app/code/Magento/SalesRule/Test/Mftf/Test/CartPriceRuleForConfigurableProductTest.xml

@@ -74,6 +74,10 @@
                 <requiredEntity createDataKey="createConfigProduct"/>
                 <requiredEntity createDataKey="createConfigChildProduct2"/>
             </createData>
+
+            <wait stepKey="waitBeforeIndexer" time="60"/>
+            <magentoCLI command="cron:run --group=index" stepKey="runCronIndexer"/>
+
             <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
         </before>
 
@@ -118,13 +122,13 @@
         <see selector="{{AdminCartPriceRulesSection.messages}}" userInput="You saved the rule." stepKey="seeSuccessMessage"/>
 
         <!-- Add the first product to the cart -->
-        <amOnPage url="$$createConfigChildProduct1.sku$$.html" stepKey="goToProductPage1"/>
+        <amOnPage url="$$createConfigChildProduct1.urlKey$$.html" stepKey="goToProductPage1"/>
         <waitForPageLoad stepKey="waitForProductPageLoad1"/>
         <click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart1"/>
         <waitForPageLoad stepKey="waitForAddToCart1"/>
         <waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
         <!-- Add the second product to the cart -->
-        <amOnPage url="$$createConfigChildProduct2.sku$$.html" stepKey="goToProductPage2"/>
+        <amOnPage url="$$createConfigChildProduct2.urlKey$$.html" stepKey="goToProductPage2"/>
         <waitForPageLoad stepKey="waitForProductPageLoad2"/>
         <click selector="{{StorefrontProductActionSection.addToCart}}" stepKey="addProductToCart2"/>
         <waitForPageLoad stepKey="waitForAddToCart2"/>