Skip to content

Commit e4d6f25

Browse files
author
Ankur Kaneria
committed
MAGETWO-44713: Flashing error while Web Installation
- Updates to accommodate code review comment
1 parent 143ce2d commit e4d6f25

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

setup/src/Magento/Setup/Controller/Install.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function progressAction()
128128
// "install.log" file may not be created yet. Check the "install.log" is created before
129129
// trying to read from it.
130130
if (!$this->log->logfileExists()) {
131-
return $json->setVariables(['progress' => $percent, 'success' => $success, 'console' => $contents]);
131+
return $json->setVariables(['progress' => $percent, 'success' => true, 'console' => $contents]);
132132
}
133133

134134
try {

setup/src/Magento/Setup/Test/Unit/Controller/InstallTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public function testProgressActionNoInstallLogFile()
161161
$variables = $jsonModel->getVariables();
162162
$this->assertArrayHasKey('success', $variables);
163163
$this->assertArrayHasKey('console', $variables);
164-
$this->assertFalse($variables['success']);
164+
$this->assertTrue($variables['success']);
165165
$this->assertEmpty($variables['console']);
166166
$this->assertSame(0, $variables['progress']);
167167
}

0 commit comments

Comments
 (0)