Skip to content

Commit e477f50

Browse files
author
Evgeniy Miskov
committed
MAGETWO-33059: Refactor CMS module
1 parent eda544b commit e477f50

File tree

6 files changed

+12
-23
lines changed

6 files changed

+12
-23
lines changed

app/code/Magento/Cms/Controller/Adminhtml/Block.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,9 @@ public function __construct(\Magento\Backend\App\Action\Context $context, \Magen
3737
*/
3838
protected function initPage($resultPage)
3939
{
40-
$resultPage->setActiveMenu(
41-
'Magento_Cms::cms_block'
42-
)->addBreadcrumb(
43-
__('CMS'),
44-
__('CMS')
45-
)->addBreadcrumb(
46-
__('Static Blocks'),
47-
__('Static Blocks')
48-
);
40+
$resultPage->setActiveMenu('Magento_Cms::cms_block')
41+
->addBreadcrumb(__('CMS'), __('CMS'))
42+
->addBreadcrumb(__('Static Blocks'), __('Static Blocks'));
4943
return $resultPage;
5044
}
5145

app/code/Magento/Cms/Controller/Index/DefaultNoRoute.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<?php
22
/**
3-
* Default no route page action
4-
* Used if no route page don't configure or available
5-
*
63
* Copyright © 2015 Magento. All rights reserved.
74
* See COPYING.txt for license details.
85
*/

app/code/Magento/Cms/Controller/Index/NoCookies.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?php
22
/**
3-
*
43
* Copyright © 2015 Magento. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
@@ -9,17 +8,17 @@
98
class NoCookies extends \Magento\Framework\App\Action\Action
109
{
1110
/**
12-
* @var \Magento\Backend\Model\View\Result\ForwardFactory
11+
* @var \Magento\Framework\Controller\Result\ForwardFactory
1312
*/
1413
protected $resultForwardFactory;
1514

1615
/**
1716
* @param \Magento\Framework\App\Action\Context $context
18-
* @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
17+
* @param \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
1918
*/
2019
public function __construct(
2120
\Magento\Framework\App\Action\Context $context,
22-
\Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
21+
\Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
2322
) {
2423
$this->resultForwardFactory = $resultForwardFactory;
2524
parent::__construct($context);

app/code/Magento/Cms/Controller/Noroute/Index.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@
99
class Index extends \Magento\Framework\App\Action\Action
1010
{
1111
/**
12-
* @var \Magento\Backend\Model\View\Result\ForwardFactory
12+
* @var \Magento\Framework\Controller\Result\ForwardFactory
1313
*/
1414
protected $resultForwardFactory;
1515

1616
/**
1717
* @param \Magento\Framework\App\Action\Context $context
18-
* @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
18+
* @param \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
1919
*/
2020
public function __construct(
2121
\Magento\Framework\App\Action\Context $context,
22-
\Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
22+
\Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
2323
) {
2424
$this->resultForwardFactory = $resultForwardFactory;
2525
parent::__construct($context);

app/code/Magento/Cms/Controller/Page/View.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@
99
class View extends \Magento\Framework\App\Action\Action
1010
{
1111
/**
12-
* @var \Magento\Backend\Model\View\Result\ForwardFactory
12+
* @var \Magento\Framework\Controller\Result\ForwardFactory
1313
*/
1414
protected $resultForwardFactory;
1515

1616
/**
1717
* @param \Magento\Framework\App\Action\Context $context
18-
* @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
18+
* @param \Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
1919
*/
2020
public function __construct(
2121
\Magento\Framework\App\Action\Context $context,
22-
\Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
22+
\Magento\Framework\Controller\Result\ForwardFactory $resultForwardFactory
2323
) {
2424
$this->resultForwardFactory = $resultForwardFactory;
2525
parent::__construct($context);

app/code/Magento/Cms/Helper/Page.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ public function prepareResultPage(Action $action, $pageId = null)
161161
/** @var \Magento\Framework\View\Result\Page $resultPage */
162162
$resultPage = $this->resultPageFactory->create();
163163
$this->setLayoutType($inRange, $resultPage);
164-
$resultPage->initLayout();
165164
$resultPage->addHandle('cms_page_view');
166165
$resultPage->addPageLayoutHandles(['id' => $this->_page->getIdentifier()]);
167166

0 commit comments

Comments
 (0)