ACP2E-42: [Magento Cloud] Null response under items list in shopping cart with out of stock product

Author: victor-v-rad

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/AddSimpleProductToCartTest.php

@@ -209,24 +209,25 @@ public function testAddDisabledProductToCart(): void
      * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
      * @magentoApiDataFixture Magento/Catalog/_files/multiple_products.php
      * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
-     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
      * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_out_of_stock.php
      * @return void
      * @throws NoSuchEntityException
      */
     public function testAddOutOfStockProductToCart(): void
     {
         $sku = 'simple1';
+        $skuOutOfStock = 'simple_product';
         $quantity = 1;
 
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
         $query = $this->getQuery($maskedQuoteId, $sku, $quantity);
+        $this->graphQlMutation($query);
 
         $this->expectException(ResponseContainsErrorsException::class);
         $this->expectExceptionMessage(
-            'Some of the products are out of stock.'
+            'Product that you are trying to add is not available'
         );
-
+        $query = $this->getQuery($maskedQuoteId, $skuOutOfStock, $quantity);
         $this->graphQlMutation($query);
     }
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetCartTest.php

@@ -62,6 +62,41 @@ public function testGetCart()
         self::assertEquals('virtual-product', $response['cart']['items'][1]['product']['sku']);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/Catalog/_files/product_virtual.php
+     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
+     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_virtual_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_out_of_stock.php
+     */
+    public function testCartErrorWithOutOfStockItem()
+    {
+        $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
+        $query = $this->getQuery($maskedQuoteId);
+
+        $response = $this->graphQlQuery($query);
+
+        self::assertArrayHasKey('cart', $response);
+        self::assertArrayHasKey('items', $response['cart']);
+        self::assertArrayHasKey('errors', $response['cart']['items'][0]);
+        self::assertEquals(
+            'There are no source items with the in stock status',
+            $response['cart']['items'][0]['errors'][0]['message']
+        );
+        self::assertArrayHasKey('id', $response['cart']);
+        self::assertEquals($maskedQuoteId, $response['cart']['id']);
+        self::assertCount(2, $response['cart']['items']);
+
+        self::assertNotEmpty($response['cart']['items'][0]['id']);
+        self::assertEquals(2, $response['cart']['items'][0]['quantity']);
+        self::assertEquals('simple_product', $response['cart']['items'][0]['product']['sku']);
+
+        self::assertNotEmpty($response['cart']['items'][1]['id']);
+        self::assertEquals(2, $response['cart']['items'][1]['quantity']);
+        self::assertEquals('virtual-product', $response['cart']['items'][1]['product']['sku']);
+    }
+
     /**
      * _security
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
@@ -279,6 +314,10 @@ private function getQuery(string $maskedQuoteId): string
           currency
         }
       }
+      errors {
+        code
+        message
+      }
     }
   }
 }