Skip to content

Commit e3ec278

Browse files
committed
MC-32387: Add pagination support to categoryList query
1 parent fc28ad0 commit e3ec278

File tree

4 files changed

+2
-14
lines changed

4 files changed

+2
-14
lines changed

app/code/Magento/CatalogGraphQl/Model/Resolver/CategoriesQuery.php

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
1515
use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\CategoryTree;
1616
use Magento\CatalogGraphQl\Model\Category\CategoryFilter;
17-
use Magento\Catalog\Model\ResourceModel\Category\CollectionFactory;
1817

1918
/**
2019
* Categories resolver, used for GraphQL category data request processing.
@@ -26,11 +25,6 @@ class CategoriesQuery implements ResolverInterface
2625
*/
2726
private $categoryTree;
2827

29-
/**
30-
* @var CollectionFactory
31-
*/
32-
private $collectionFactory;
33-
3428
/**
3529
* @var CategoryFilter
3630
*/
@@ -45,18 +39,15 @@ class CategoriesQuery implements ResolverInterface
4539
* @param CategoryTree $categoryTree
4640
* @param ExtractDataFromCategoryTree $extractDataFromCategoryTree
4741
* @param CategoryFilter $categoryFilter
48-
* @param CollectionFactory $collectionFactory
4942
*/
5043
public function __construct(
5144
CategoryTree $categoryTree,
5245
ExtractDataFromCategoryTree $extractDataFromCategoryTree,
53-
CategoryFilter $categoryFilter,
54-
CollectionFactory $collectionFactory
46+
CategoryFilter $categoryFilter
5547
) {
5648
$this->categoryTree = $categoryTree;
5749
$this->extractDataFromCategoryTree = $extractDataFromCategoryTree;
5850
$this->categoryFilter = $categoryFilter;
59-
$this->collectionFactory = $collectionFactory;
6051
}
6152

6253
/**

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoriesQuery/CategoriesFilterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ public function testEmptyFiltersReturnRootCategory()
368368
*
369369
* @magentoApiDataFixture Magento/Catalog/_files/categories.php
370370
* @expectedException \Exception
371-
* @expectedExceptionMessage Invalid match filter. Minimum query length is 3.
371+
* @expectedExceptionMessage Invalid match filter. Minimum length is 3.
372372
*/
373373
public function testMinimumMatchQueryLength()
374374
{

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoriesQuery/CategoriesPaginationTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
namespace Magento\GraphQl\Catalog\CategoriesQuery;
99

1010
use Magento\TestFramework\TestCase\GraphQlAbstract;
11-
use function sprintf;
1211

1312
/**
1413
* Test pagination for the categories query

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoriesQuery/CategoryTreeTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515
use Magento\Store\Model\Store;
1616
use Magento\Store\Model\StoreManagerInterface;
1717
use Magento\TestFramework\ObjectManager;
18-
use Magento\TestFramework\TestCase\GraphQl\ResponseContainsErrorsException;
1918
use Magento\TestFramework\TestCase\GraphQlAbstract;
20-
use function assertCount;
2119

2220
/**
2321
* Test category tree data is returned correctly from "categories" query

0 commit comments

Comments
 (0)