#27499: Code review fixes.

Author: Stanislav Idolov

app/code/Magento/MediaGallery/Model/Asset/Command/Save.php

@@ -61,22 +61,26 @@ public function execute(AssetInterface $mediaAsset): int
             /** @var \Magento\Framework\DB\Adapter\Pdo\Mysql $connection */
             $connection = $this->resourceConnection->getConnection();
             $tableName = $this->resourceConnection->getTableName(self::TABLE_MEDIA_GALLERY_ASSET);
+            $record = [
+                'id' => $mediaAsset->getId(),
+                'path' => $mediaAsset->getPath(),
+                'title' => $mediaAsset->getTitle(),
+                'source' => $mediaAsset->getSource(),
+                'content_type' => $mediaAsset->getContentType(),
+                'width' => $mediaAsset->getWidth(),
+                'height' => $mediaAsset->getHeight(),
+                'size' => $mediaAsset->getSize(),
+            ];
 
-            $connection->insertOnDuplicate(
-                $tableName,
-                [
-                    'id' => $mediaAsset->getId(),
-                    'path' => $mediaAsset->getPath(),
-                    'title' => $mediaAsset->getTitle(),
-                    'source' => $mediaAsset->getSource(),
-                    'content_type' => $mediaAsset->getContentType(),
-                    'width' => $mediaAsset->getWidth(),
-                    'height' => $mediaAsset->getHeight(),
-                    'size' => $mediaAsset->getSize(),
-                    'created_at' => $mediaAsset->getCreatedAt(),
-                    'updated_at' => $mediaAsset->getUpdatedAt(),
-                ]
-            );
+            if ($mediaAsset->getCreatedAt()) {
+                $record['created_at'] = $mediaAsset->getCreatedAt();
+            }
+
+            if ($mediaAsset->getUpdatedAt()) {
+                $record['updated_at'] = $mediaAsset->getUpdatedAt();
+            }
+
+            $connection->insertOnDuplicate($tableName, $record);
             return (int)$connection->lastInsertId($tableName);
         } catch (\Exception $exception) {
             $this->logger->critical($exception);

app/code/Magento/MediaGallery/Model/ResourceModel/SaveAssets.php

@@ -56,21 +56,26 @@ public function execute(array $assets): void
         $failedAssets = [];
         foreach ($assets as $asset) {
             try {
-                $connection->insertOnDuplicate(
-                    $tableName,
-                    [
-                        'id' => $asset->getId(),
-                        'path' => $asset->getPath(),
-                        'title' => $asset->getTitle(),
-                        'source' => $asset->getSource(),
-                        'content_type' => $asset->getContentType(),
-                        'width' => $asset->getWidth(),
-                        'height' => $asset->getHeight(),
-                        'size' => $asset->getSize(),
-                        'created_at' => $asset->getCreatedAt(),
-                        'updated_at' => $asset->getUpdatedAt(),
-                    ]
-                );
+                $record = [
+                    'id' => $asset->getId(),
+                    'path' => $asset->getPath(),
+                    'title' => $asset->getTitle(),
+                    'source' => $asset->getSource(),
+                    'content_type' => $asset->getContentType(),
+                    'width' => $asset->getWidth(),
+                    'height' => $asset->getHeight(),
+                    'size' => $asset->getSize(),
+                ];
+
+                if ($asset->getCreatedAt()) {
+                    $record['created_at'] = $asset->getCreatedAt();
+                }
+
+                if ($asset->getUpdatedAt()) {
+                    $record['updated_at'] = $asset->getUpdatedAt();
+                }
+
+                $connection->insertOnDuplicate($tableName, $record);
             } catch (\Exception $exception) {
                 $this->logger->critical($exception);
                 $failedAssets[] = $asset;

app/code/Magento/MediaGallery/etc/db_schema.xml

@@ -26,6 +26,9 @@
         <constraint xsi:type="unique" referenceId="MEDIA_GALLERY_ID_PATH_TITLE_CONTENT_TYPE_WIDTH_HEIGHT">
             <column name="path"/>
         </constraint>
+        <index referenceId="MEDIA_GALLERY_ASSET_TITLE" indexType="fulltext">
+            <column name="title"/>
+        </index>
     </table>
     <table name="media_gallery_keyword" resource="default" engine="innodb" comment="Media Gallery Keyword">
         <column xsi:type="int" name="id" padding="10" unsigned="true" nullable="false" identity="true" comment="Keyword ID"/>