Skip to content

Commit e3aa84e

Browse files
ENGCOM-9324: Replace repetitive actions with Action Groups in AdminUpdateFlatCategoryNameAndDescriptionTest #34492
- Merge Pull Request #34492 from kate-kyzyma/magento2:Refactoring-AdminUpdateFlatCategoryNameAndDescriptionTest - Merged commits: 1. 14b41be
2 parents b7b5d58 + 14b41be commit e3aa84e

File tree

1 file changed

+37
-17
lines changed

1 file changed

+37
-17
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateFlatCategoryNameAndDescriptionTest.xml

Lines changed: 37 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,21 @@
5353
<!-- Select Created Category-->
5454
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openAdminCategoryIndexPage"/>
5555
<actionGroup ref="AdminExpandCategoryTreeActionGroup" stepKey="clickOnExpandTree"/>
56-
<click selector="{{AdminCategorySidebarTreeSection.categoryInTree(_defaultCategory.name)}}" stepKey="selectCreatedCategory"/>
57-
<waitForPageLoad stepKey="waitForPageToLoaded"/>
56+
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="selectCreatedCategory">
57+
<argument name="category" value="_defaultCategory"/>
58+
</actionGroup>
59+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToLoaded"/>
5860
<!--Update Category Name and Description -->
59-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="addSubCategoryName"/>
61+
<actionGroup ref="AdminChangeCategoryNameActionGroup" stepKey="addSubCategoryName">
62+
<argument name="categoryName" value="{{SimpleSubCategory.name}}"/>
63+
</actionGroup>
6064
<scrollTo selector="{{AdminCategoryContentSection.sectionHeader}}" x="0" y="-80" stepKey="scrollToContent"/>
6165
<click selector="{{AdminCategoryContentSection.sectionHeader}}" stepKey="selectContent"/>
6266
<fillField selector="{{AdminCategoryContentSection.description}}" userInput="Updated category Description Fields" stepKey="fillUpdatedDescription"/>
6367
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveSubCategory"/>
64-
<seeElement selector="{{AdminCategoryMessagesSection.SuccessMessage}}" stepKey="seeSuccessMessage"/>
68+
<actionGroup ref="AssertMessageInAdminPanelActionGroup" stepKey="seeSuccessMessage">
69+
<argument name="message" value="You saved the category."/>
70+
</actionGroup>
6571
<!--Run full reindex and clear caches -->
6672
<actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
6773
<argument name="indices" value="catalog_category_flat"/>
@@ -70,24 +76,38 @@
7076
<actionGroup ref="AdminOpenIndexManagementPageActionGroup" stepKey="openIndexManagementPage"/>
7177
<see stepKey="seeIndexStatus" selector="{{AdminIndexManagementSection.indexerStatus('Category Flat Data')}}" userInput="READY"/>
7278
<!--Verify Category In Store Front-->
73-
<amOnPage url="{{SimpleSubCategory.urlKey}}.html" stepKey="goToStorefrontPage"/>
74-
<waitForPageLoad stepKey="waitForPageToBeLoaded"/>
79+
<actionGroup ref="StorefrontGoToCategoryPageActionGroup" stepKey="goToStorefrontPage">
80+
<argument name="categoryName" value="{{SimpleSubCategory.name}}"/>
81+
</actionGroup>
82+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForPageToBeLoaded"/>
7583
<!--Verify category is visible in First Store View -->
76-
<click stepKey="selectStoreSwitcher" selector="{{StorefrontHeaderSection.storeViewSwitcher}}"/>
77-
<click stepKey="selectFirstStoreView" selector="{{StorefrontHeaderSection.storeViewList(customStoreEN.name)}}"/>
78-
<waitForPageLoad stepKey="waitForFirstStoreView"/>
79-
<seeElement selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleSubCategory.name)}}" stepKey="seeCategoryOnNavigation"/>
84+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectStoreSwitcher"/>
85+
<actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="selectFirstStoreView">
86+
<argument name="storeView" value="customStoreEN"/>
87+
</actionGroup>
88+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForFirstStoreView"/>
89+
<actionGroup ref="StorefrontAssertCategoryNameIsShownInMenuActionGroup" stepKey="seeCategoryOnNavigation">
90+
<argument name="categoryName" value="{{SimpleSubCategory.name}}"/>
91+
</actionGroup>
8092
<!--Verify category is visible in Second Store View -->
81-
<click stepKey="selectStoreSwitcher1" selector="{{StorefrontHeaderSection.storeViewSwitcher}}"/>
82-
<click stepKey="selectSecondStoreView" selector="{{StorefrontHeaderSection.storeViewList(customStoreFR.name)}}"/>
83-
<waitForPageLoad stepKey="waitForSecondStoreView"/>
84-
<seeElement selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleSubCategory.name)}}" stepKey="seeCategoryOnNavigation1"/>
93+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="selectStoreSwitcher1"/>
94+
<actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="selectSecondStoreView">
95+
<argument name="storeView" value="customStoreFR"/>
96+
</actionGroup>
97+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForSecondStoreView"/>
98+
<actionGroup ref="StorefrontAssertCategoryNameIsShownInMenuActionGroup" stepKey="seeCategoryOnNavigation1">
99+
<argument name="categoryName" value="{{SimpleSubCategory.name}}"/>
100+
</actionGroup>
85101
<!-- Verify Updated Category Name and description on Category Page-->
86102
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openAdminCategoryIndexPage1"/>
87103
<actionGroup ref="AdminExpandCategoryTreeActionGroup" stepKey="clickOnExpandTree1"/>
88-
<click selector="{{AdminCategorySidebarTreeSection.categoryInTree(SimpleSubCategory.name)}}" stepKey="selectUpdatedCategory"/>
89-
<waitForPageLoad stepKey="waitForUpdatedCategoryPageToLoad"/>
90-
<seeInField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="seeUpdatedSubCategoryName"/>
104+
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="selectUpdatedCategory">
105+
<argument name="category" value="SimpleSubCategory"/>
106+
</actionGroup>
107+
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForUpdatedCategoryPageToLoad"/>
108+
<actionGroup ref="AssertAdminCategoryPageTitleActionGroup" stepKey="seeUpdatedSubCategoryName">
109+
<argument name="categoryName" value="{{SimpleSubCategory.name}}"/>
110+
</actionGroup>
91111
<scrollTo selector="{{AdminCategoryContentSection.sectionHeader}}" x="0" y="-80" stepKey="scrollToContent1"/>
92112
<click selector="{{AdminCategoryContentSection.sectionHeader}}" stepKey="selectContent1"/>
93113
<seeInField selector="{{AdminCategoryContentSection.description}}" userInput="Updated category Description Fields" stepKey="seeUpdatedDescription"/>

0 commit comments

Comments
 (0)