MAGETWO-37729: Stock is not updated when Stock indexer is in Update on Schedule mode

Author: Yaroslav Onischenko

app/code/Magento/CatalogInventory/Model/Resource/Stock/Item.php

@@ -123,6 +123,7 @@ protected function _afterSave(AbstractModel $object)
         parent::_afterSave($object);
         /** @var StockItemInterface $object */
         if ($this->processIndexEvents) {
+            $this->stockIndexerProcessor->markIndexerAsInvalid();
             $this->stockIndexerProcessor->reindexRow($object->getProductId());
         }
         return $this;

app/code/Magento/Indexer/etc/crontab.xml

@@ -6,7 +6,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../Cron/etc/crontab.xsd">
-    <group id="index">
+    <group id="default">
         <job name="indexer_reindex_all_invalid" instance="Magento\Indexer\Model\Processor" method="reindexAllInvalid">
             <schedule>* * * * *</schedule>
         </job>

dev/tests/integration/testsuite/Magento/CatalogInventory/Model/Stock/ItemTest.php

@@ -5,6 +5,8 @@
  */
 namespace Magento\CatalogInventory\Model\Stock;
 
+use Magento\Indexer\Model\Indexer\State;
+
 class ItemTest extends \PHPUnit_Framework_TestCase
 {
     /**
@@ -21,6 +23,7 @@ protected function setUp()
 
     /**
      * @magentoDataFixture Magento/Catalog/_files/products.php
+     * @magentoAppIsolation enabled
      */
     public function testSaveWithNullQty()
     {
@@ -31,11 +34,11 @@ public function testSaveWithNullQty()
         $product->load(1);
 
         /** @var \Magento\CatalogInventory\Model\Stock\StockItemRepository $stockItemRepository */
-        $stockItemRepository = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+        $stockItemRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
             ->create('Magento\CatalogInventory\Model\Stock\StockItemRepository');
 
         /** @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface $stockItemCriteria */
-        $stockItemCriteria = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+        $stockItemCriteria = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
             ->create('Magento\CatalogInventory\Api\StockItemCriteriaInterface');
 
         $savedStockItem = current($stockItemRepository->getList($stockItemCriteria)->getItems());
@@ -60,15 +63,46 @@ public function testSaveWithNullQty()
 
     /**
      * @magentoDataFixture Magento/Catalog/_files/products.php
+     * @magentoAppIsolation enabled
+     */
+    public function testIndexerInvalidation()
+    {
+        /** @var \Magento\CatalogInventory\Model\Stock\StockItemRepository $stockItemRepository */
+        $stockItemRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+            ->create('Magento\CatalogInventory\Model\Stock\StockItemRepository');
+
+        /** @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface $stockItemCriteria */
+        $stockItemCriteria = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+            ->create('Magento\CatalogInventory\Api\StockItemCriteriaInterface');
+        /** @var \Magento\CatalogInventory\Model\Indexer\Stock\Processor $indexerProcessor */
+        $indexerProcessor = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+            ->create('Magento\CatalogInventory\Model\Indexer\Stock\Processor');
+        $indexer = $indexerProcessor->getIndexer();
+        $indexer->setScheduled(true);
+        $indexer->getState()->setStatus(State::STATUS_VALID)->save();
+
+        /** @var \Magento\CatalogInventory\Api\Data\StockItemInterface $savedStockItem */
+        $savedStockItem = current($stockItemRepository->getList($stockItemCriteria)->getItems());
+        $savedStockItem->setQty(1);
+        $savedStockItem->setIsInStock(false);
+        $savedStockItem->save();
+
+
+        $this->assertEquals('invalid', $indexerProcessor->getIndexer()->getStatus());
+    }
+
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/products.php
+     * @magentoAppIsolation enabled
      */
     public function testStockStatusChangedAuto()
     {
         /** @var \Magento\CatalogInventory\Model\Stock\StockItemRepository $stockItemRepository */
-        $stockItemRepository = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+        $stockItemRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
             ->create('Magento\CatalogInventory\Model\Stock\StockItemRepository');
 
         /** @var \Magento\CatalogInventory\Api\StockItemCriteriaInterface $stockItemCriteria */
-        $stockItemCriteria = $product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+        $stockItemCriteria = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
             ->create('Magento\CatalogInventory\Api\StockItemCriteriaInterface');
 
         $savedStockItem = current($stockItemRepository->getList($stockItemCriteria)->getItems());