ENGCOM-669: Pass Expected Data Type in backgroundColor Call (2.3) #13917

Stanislav Idolov · web-flow · commit e32bd985b3be · 2018-03-04T11:32:15.000+02:00
diff --git a/app/code/Magento/Swatches/Helper/Media.php b/app/code/Magento/Swatches/Helper/Media.php
@@ -211,7 +211,7 @@ protected function setupImageProperties(\Magento\Framework\Image $image, $isSwat
         if ($isSwatch) {
             $image->keepFrame(true);
             $image->keepTransparency(true);
-            $image->backgroundColor('#FFF');
+            $image->backgroundColor([255, 255, 255]);
         }
         return $this;
     }
diff --git a/app/code/Magento/Swatches/Test/Unit/Helper/MediaTest.php b/app/code/Magento/Swatches/Test/Unit/Helper/MediaTest.php
@@ -158,6 +158,7 @@ public function testGenerateSwatchVariations()
         $this->imageFactoryMock->expects($this->any())->method('create')->willReturn($image);
         $this->generateImageConfig();
         $image->expects($this->any())->method('resize')->will($this->returnSelf());
+        $image->expects($this->atLeastOnce())->method('backgroundColor')->with([255, 255, 255])->willReturnSelf();
         $this->mediaHelperObject->generateSwatchVariations('/e/a/earth.png');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ protected function setupImageProperties(\Magento\Framework\Image $image, $isSwat`
`211`	`211`	`if ($isSwatch) {`
`212`	`212`	`$image->keepFrame(true);`
`213`	`213`	`$image->keepTransparency(true);`
`214`		`- $image->backgroundColor('#FFF');`
	`214`	`+ $image->backgroundColor([255, 255, 255]);`
`215`	`215`	`}`
`216`	`216`	`return $this;`
`217`	`217`	`}`
Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,7 @@ public function testGenerateSwatchVariations()`
`158`	`158`	`$this->imageFactoryMock->expects($this->any())->method('create')->willReturn($image);`
`159`	`159`	`$this->generateImageConfig();`
`160`	`160`	`$image->expects($this->any())->method('resize')->will($this->returnSelf());`
	`161`	`+ $image->expects($this->atLeastOnce())->method('backgroundColor')->with([255, 255, 255])->willReturnSelf();`
`161`	`162`	`$this->mediaHelperObject->generateSwatchVariations('/e/a/earth.png');`
`162`	`163`	`}`
`163`	`164`