MAGETWO-51890: Fix unreliable implementation

irenelagno · irenelagno · commit e31ffaf277f6 · 2016-04-29T15:11:49.000+03:00
diff --git a/app/code/Magento/Checkout/Model/ShippingInformationManagement.php b/app/code/Magento/Checkout/Model/ShippingInformationManagement.php
@@ -199,7 +199,7 @@ private function prepareShippingAssignment(CartInterface $quote, AddressInterfac
         }
 
         $shippingAssignments = $cartExtension->getShippingAssignments();
-        if ($shippingAssignments === null || empty($shippingAssignments)) {
+        if (empty($shippingAssignments)) {
             $shippingAssignment = $this->getShippingAssignmentFactory()->create();
         } else {
             $shippingAssignment = $shippingAssignments[0];

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ private function prepareShippingAssignment(CartInterface $quote, AddressInterfac`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`$shippingAssignments = $cartExtension->getShippingAssignments();`
`202`		`- if ($shippingAssignments === null \|\| empty($shippingAssignments)) {`
	`202`	`+ if (empty($shippingAssignments)) {`
`203`	`203`	`$shippingAssignment = $this->getShippingAssignmentFactory()->create();`
`204`	`204`	`} else {`
`205`	`205`	`$shippingAssignment = $shippingAssignments[0];`