MAGETWO-44695: [github] Performance bug: getAfterElementHtml() method implementation #2189

Author: Oleh Posyniak

lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php

@@ -345,15 +345,18 @@ protected function _getUiId($suffix = null)
     public function getElementHtml()
     {
         $html = '';
-        if ($this->getBeforeElementHtml() && $this->getBeforeElementHtml() != '') {
+        $htmlId = $this->getHtmlId();
+
+        if (($beforeElementHtml = $this->getBeforeElementHtml())) {
             $html .= '<label class="addbefore" for="' .
-                $this->getHtmlId() .
+                $htmlId .
                 '">' .
-                $this->getBeforeElementHtml() .
+                $beforeElementHtml .
                 '</label>';
         }
+
         $html .= '<input id="' .
-            $this->getHtmlId() .
+            $htmlId .
             '" name="' .
             $this->getName() .
             '" ' .
@@ -364,16 +367,19 @@ public function getElementHtml()
             $this->serialize(
                 $this->getHtmlAttributes()
             ) . '/>';
-        if ($this->getAfterElementJs() && $this->getAfterElementJs() != '') {
-            $html .= $this->getAfterElementJs();
+
+        if (($afterElementJs = $this->getAfterElementJs())) {
+            $html .= $afterElementJs;
         }
-        if ($this->getAfterElementHtml() && $this->getAfterElementHtml() != '') {
+
+        if (($afterElementHtml = $this->getAfterElementHtml())) {
             $html .= '<label class="addafter" for="' .
-                $this->getHtmlId() .
+                $htmlId .
                 '">' .
-                $this->getAfterElementHtml() .
+                $afterElementHtml .
                 '</label>';
         }
+
         return $html;
     }