Skip to content

Commit e2c9ac0

Browse files
committed
Rename recurcive method to have more clear understanding
1 parent b777343 commit e2c9ac0

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ExtractDataFromCategoryTree.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function execute(\Iterator $iterator): array
5353
$pathElements = explode("/", $category->getPath());
5454
$this->iteratingCategory = $category;
5555

56-
$currentLevelTree = $this->generateLevelTree($pathElements, self::START_CATEGORY_FETCH_LEVEL);
56+
$currentLevelTree = $this->explodePathToArray($pathElements, self::START_CATEGORY_FETCH_LEVEL);
5757
if (empty($tree)) {
5858
$tree = $currentLevelTree;
5959
}
@@ -64,7 +64,7 @@ public function execute(\Iterator $iterator): array
6464
}
6565

6666
/**
67-
* Merge together complex categories tree
67+
* Merge together complex categories trees
6868
*
6969
* @param array $tree1
7070
* @param array $tree2
@@ -86,23 +86,23 @@ private function mergeCategoriesTrees(array &$tree1, array &$tree2): array
8686
/**
8787
* Recursive method to generate tree for one category path
8888
*
89-
* @param $elements
89+
* @param $pathElements
9090
* @param $index
9191
* @return array
9292
*/
93-
private function generateLevelTree($elements, $index): array
93+
private function explodePathToArray($pathElements, $index): array
9494
{
9595

9696
$tree = [];
97-
$tree[$elements[$index]]['id'] = $elements[$index];
98-
if ($index === count($elements) - 1) {
99-
$tree[$elements[$index]] = $this->categoryHydrator->hydrateCategory($this->iteratingCategory);
100-
$tree[$elements[$index]]['model'] = $this->iteratingCategory;
97+
$tree[$pathElements[$index]]['id'] = $pathElements[$index];
98+
if ($index === count($pathElements) - 1) {
99+
$tree[$pathElements[$index]] = $this->categoryHydrator->hydrateCategory($this->iteratingCategory);
100+
$tree[$pathElements[$index]]['model'] = $this->iteratingCategory;
101101
}
102102
$currentIndex = $index;
103103
$index++;
104-
if (isset($elements[$index])) {
105-
$tree[$elements[$currentIndex]]['children'] = $this->generateLevelTree($elements, $index);
104+
if (isset($pathElements[$index])) {
105+
$tree[$pathElements[$currentIndex]]['children'] = $this->explodePathToArray($pathElements, $index);
106106
}
107107
return $tree;
108108
}

0 commit comments

Comments
 (0)