ACP2E-72: Search results suggestion give total count of 0 even though there are products

 - Fixed the CR Comments.

Author: devarul

app/code/Magento/Search/Model/QueryResult.php

@@ -5,6 +5,10 @@
  */
 namespace Magento\Search\Model;
 
+use Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Search\Model\ResourceModel\Query\CollectionFactory as QueryCollectionFactory;
+use Magento\Store\Model\StoreManagerInterface;
+
 /**
  * @api
  * @since 100.0.2
@@ -14,36 +18,63 @@ class QueryResult
     /**
      * @var string
      */
-    private $queryText;
+    private string $queryText;
 
     /**
      * @var int
      */
     private $resultsCount;
 
     /**
-     * @param string $queryText
-     * @param string $resultsCount
+     * @var QueryCollectionFactory
      */
-    public function __construct($queryText, $resultsCount)
-    {
+    private QueryCollectionFactory $queryCollectionFactory;
+
+    /**
+     * @var StoreManagerInterface
+     */
+    private StoreManagerInterface $storeManager;
+
+    /**
+     * @param $queryText
+     * @param $resultsCount
+     * @param QueryCollectionFactory $queryCollectionFactory
+     * @param StoreManagerInterface $storeManager
+     */
+    public function __construct(
+        $queryText,
+        $resultsCount,
+        QueryCollectionFactory $queryCollectionFactory,
+        StoreManagerInterface  $storeManager
+    ) {
         $this->queryText = $queryText;
         $this->resultsCount = $resultsCount;
+        $this->queryCollectionFactory = $queryCollectionFactory;
+        $this->storeManager = $storeManager;
     }
 
     /**
      * @return string
      */
-    public function getQueryText()
+    public function getQueryText(): string
     {
         return $this->queryText;
     }
 
     /**
      * @return int
+     * @throws NoSuchEntityException
      */
-    public function getResultsCount()
+    public function getResultsCount(): int
     {
+        $collection = $this->queryCollectionFactory->create()->setStoreId(
+            $this->storeManager->getStore()->getId()
+        )->setQueryFilter(
+            $this->getQueryText()
+        );
+        foreach ($collection as $item) {
+            $this->resultsCount = $item->getData('num_results');
+        }
         return $this->resultsCount;
     }
 }

app/code/Magento/Search/Plugin/Model/SearchSuggestionResultsCount.php

@@ -7,66 +7,157 @@
 
 namespace Magento\Search\Test\Unit\Model;
 
+use Magento\Framework\Data\Collection\AbstractDb;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Search\Model\QueryResult;
+use Magento\Search\Model\ResourceModel\Query\Collection;
+use Magento\Search\Model\ResourceModel\Query\CollectionFactory as QueryCollectionFactory;
+use Magento\Store\Api\Data\StoreInterface;
+use Magento\Store\Model\StoreManagerInterface;
 use PHPUnit\Framework\TestCase;
 
 class QueryResultTest extends TestCase
 {
+    /**
+     * @var QueryResult
+     */
+    private QueryResult $model;
+
     /**
      * @var ObjectManager
      */
-    private $objectManager;
+    private ObjectManager $objectManager;
+
+    /**
+     * @var QueryCollectionFactory
+     */
+    private QueryCollectionFactory $queryCollectionFactoryMock;
+
+    /**
+     * @var StoreManagerInterface
+     */
+    private StoreManagerInterface $storeManagerMock;
+
+    /**
+     * @var StoreInterface
+     */
+    private StoreInterface $storeInterfaceMock;
+
+    /**
+     * @var Collection
+     */
+    private Collection $queryCollectionMock;
+
+    /**
+     * @var QueryResult
+     */
+    private QueryResult $queryResultMock;
+
+    /**
+     * @var AbstractDb
+     */
+    private AbstractDb $abstractDbMock;
 
     protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
+        $this->queryCollectionFactoryMock = $this->getMockBuilder(QueryCollectionFactory::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['create'])
+            ->getMock();
+        $this->storeManagerMock = $this->getMockBuilder(StoreManagerInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->storeInterfaceMock = $this->getMockBuilder(StoreInterface::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getId'])
+            ->getMockForAbstractClass();
+        $this->queryCollectionMock = $this->getMockBuilder(Collection::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->queryResultMock = $this->getMockBuilder(QueryResult::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->abstractDbMock = $this->getMockBuilder(AbstractDb::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getData'])
+            ->getMockForAbstractClass();
+        $this->model = new QueryResult(
+            'mint',
+            'resultsCount',
+            $this->queryCollectionFactoryMock,
+            $this->storeManagerMock
+        );
     }
 
     /**
      * @dataProvider getPropertiesDataProvider
      */
-    public function testGetProperties($queryText, $resultsCount)
+    public function testGetProperties($queryText)
     {
         /** @var QueryResult $queryResult */
         $queryResult = $this->objectManager->getObject(
             QueryResult::class,
             [
-                'queryText' => $queryText,
-                'resultsCount' => $resultsCount,
+                'queryText' => $queryText
             ]
         );
         $this->assertEquals($queryText, $queryResult->getQueryText());
-        $this->assertEquals($resultsCount, $queryResult->getResultsCount());
     }
 
     /**
      * Data provider for testGetProperties
      * @return array
      */
-    public function getPropertiesDataProvider()
+    public function getPropertiesDataProvider(): array
     {
         return [
             [
-                'queryText' => 'Some kind of query text',
-                'resultsCount' => 0,
+                'queryText' => 'Some kind of query text'
             ],
             [
-                'queryText' => 'Another query',
-                'resultsCount' => 322312312,
+                'queryText' => 'Another query'
             ],
             [
-                'queryText' => 'It\' a query too',
-                'resultsCount' => -100,
+                'queryText' => 'It\' a query too'
             ],
             [
-                'queryText' => '',
-                'resultsCount' => null,
+                'queryText' => ''
             ],
             [
-                'queryText' => 42,
-                'resultsCount' => false,
+                'queryText' => 42
             ],
         ];
     }
+
+    /**
+     * @return void
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    public function testAfterGetResultsCount()
+    {
+        $expectedArr = ['num_results' => 5];
+        $this->queryCollectionFactoryMock->expects($this->once())
+            ->method('create')
+            ->willReturn($this->queryCollectionMock);
+        $this->storeManagerMock->expects($this->once())
+            ->method('getStore')
+            ->willReturn($this->storeInterfaceMock);
+        $this->storeInterfaceMock->expects($this->once())
+            ->method('getId')
+            ->willReturn(1);
+        $this->queryCollectionMock->expects($this->once())
+            ->method('setStoreId')
+            ->willReturnSelf();
+        $this->queryCollectionMock->expects($this->once())
+            ->method('setQueryFilter')
+            ->willReturn($this->queryCollectionMock);
+        $this->abstractDbMock->expects($this->once())
+            ->method('getData')
+            ->willReturn(['num_results' => 5]);
+        $this->queryCollectionMock->expects($this->once())
+            ->method('getIterator')
+            ->willReturn(new \ArrayIterator([$this->abstractDbMock]));
+        $this->assertEquals($expectedArr, $this->model->getResultsCount());
+    }
 }