MAGETWO-33669: Contribution of Sprint 23 Work to Mainline

- various formatting fixes for static code tests

Author: monkeysee

dev/tests/unit/testsuite/Magento/Framework/Module/StatusTest.php

@@ -73,7 +73,7 @@ public function testCheckConstraintsEnableAllowed()
             true,
             ['Module_Foo' => '', 'Module_Bar' => ''],
             ['Module_baz', 'Module_quz']
-            );
+        );
         $this->assertEquals([], $result);
     }
 

dev/tests/unit/testsuite/Magento/Setup/Model/ModuleStatusTest.php

@@ -86,7 +86,7 @@ public function testGetAllModulesWithInputs($expectedAllModules, $expectedConfig
         );
 
         $moduleStatus = new ModuleStatus($this->moduleLoader, $this->deploymentConfig, $this->objectManagerProvider);
-        $allModules = $moduleStatus->getAllModules(['module1' , 'module2']);
+        $allModules = $moduleStatus->getAllModules(['module1', 'module2']);
         $this->assertSame(true, $allModules['module1']['selected']);
         $this->assertSame(true, $allModules['module2']['selected']);
         $this->assertSame(false, $allModules['module3']['selected']);

setup/src/Magento/Setup/Controller/Install.php

@@ -141,7 +141,7 @@ private function importDeploymentConfigForm()
         $result[Installer::ENABLE_MODULES] = isset($source['store']['selectedModules'])
             ? implode(',', $source['store']['selectedModules']) : '';
         $result[Installer::DISABLE_MODULES] = isset($source['store']['allModules'])
-            ? implode( ',', array_diff($source['store']['allModules'], $source['store']['selectedModules'])) : '';
+            ? implode(',', array_diff($source['store']['allModules'], $source['store']['selectedModules'])) : '';
         return $result;
     }
 

setup/src/Magento/Setup/Controller/Modules.php

@@ -44,7 +44,7 @@ public function indexAction()
     {
         $allModules = $this->allModules->getAllModules();
         $enabledModules = [];
-        foreach ($allModules as $module ) {
+        foreach ($allModules as $module) {
             if ($module['selected']) {
                 $enabledModules[] = $module['name'];
             }
@@ -55,7 +55,7 @@ public function indexAction()
             return new JsonModel(['success' => true, 'modules' => $allModules]);
         } else {
             $errorMessage = $validity->getVariable("error");
-            return new JsonModel(['success' => false,  'modules' => $allModules,
+            return new JsonModel(['success' => false, 'modules' => $allModules,
                 'error' => '<b> Corrupt config.php!</b> <br />' . $errorMessage]);
         }
     }
@@ -103,8 +103,11 @@ public function validateAction()
         $params = Json::decode($this->getRequest()->getContent(), Json::TYPE_ARRAY);
         $status = $this->objectManager->create('Magento\Framework\Module\Status');
 
-        $constraints = $status->checkConstraints($params['status'], [$params['module']],
-            array_diff($params['selectedModules'], [$params['module']]));
+        $constraints = $status->checkConstraints(
+            $params['status'],
+            [$params['module']],
+            array_diff($params['selectedModules'], [$params['module']])
+        );
         if ($constraints) {
             $message = $this->getConstraintsFailureMessage($params['status'], $constraints);
             return new JsonModel(['success' => false, 'error' => $message]);