Skip to content

Commit e0c7fae

Browse files
🔃 [EngCom] Public Pull Requests - 2.1-develop
Accepted Public Pull Requests: - #15238: [Backport] Fixed php notice when invalid ui_component config is used (by @VitaliyBoyko) - #15234: [Backport] Add missing translations in Magento_UI (by @VitaliyBoyko) - #15233: [Backport] Fix typo in design rule hint message (by @VitaliyBoyko)
2 parents cecccb0 + 3c2a747 commit e0c7fae

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

app/code/Magento/Backend/view/adminhtml/web/template/dynamic-rows/grid.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
<div class="messages">
8686
<div class="message message-notice notice">
8787
<span
88-
translate="'Search strings are either normal strings or regular exceptions (PCRE). They are matched in the same order as entered.'"></span>
88+
translate="'Search strings are either normal strings or regular expressions (PCRE). They are matched in the same order as entered.'"></span>
8989
<br>
9090
<span
9191
translate="'Examples'"></span>:

app/code/Magento/Ui/i18n/en_US.csv

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,3 +109,25 @@ Ok,Ok
109109
Action,Action
110110
CSV,CSV
111111
"Excel XML","Excel XML"
112+
"Please select one of the options above.","Please select one of the options above."
113+
"Please select a file.","Please select a file."
114+
"Please select one of the options.","Please select one of the options."
115+
"Please enter a value less than or equal to %s.","Please enter a value less than or equal to %s."
116+
"Please enter a value greater than or equal to %s.","Please enter a value greater than or equal to %s."
117+
"Card type does not match credit card number.","Card type does not match credit card number."
118+
"Credit card number does not match credit card type.","Credit card number does not match credit card type."
119+
"Incorrect credit card expiration date.","Incorrect credit card expiration date."
120+
"Please enter less or equal than %1 symbols.","Please enter less or equal than %1 symbols."
121+
"Please enter more or equal than %1 symbols.","Please enter more or equal than %1 symbols."
122+
"Please enter a valid value from list","Please enter a valid value from list"
123+
"Please enter valid SKU key.","Please enter valid SKU key."
124+
"Please enter a valid number.","Please enter a valid number."
125+
"Admin is a required field in the each row.","Admin is a required field in the each row."
126+
"Please fix this field.","Please fix this field."
127+
"Please enter a valid date (ISO).","Please enter a valid date (ISO)."
128+
"Please enter only digits.","Please enter only digits."
129+
"Please enter the same value again.","Please enter the same value again."
130+
"Please enter no more than {0} characters.","Please enter no more than {0} characters."
131+
"Please enter at least {0} characters.","Please enter at least {0} characters."
132+
"Please enter a value between {0} and {1} characters long.","Please enter a value between {0} and {1} characters long."
133+
"Please enter a value between {0} and {1}.","Please enter a value between {0} and {1}."

lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Copyright © 2013-2018 Magento, Inc. All rights reserved.
3+
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66
namespace Magento\Framework\ObjectManager\Factory;
@@ -127,12 +127,12 @@ protected function createObject($type, $args)
127127
protected function resolveArgument(&$argument, $paramType, $paramDefault, $paramName, $requestedType)
128128
{
129129
if ($paramType && $argument !== $paramDefault && !is_object($argument)) {
130-
$argumentType = $argument['instance'];
131130
if (!isset($argument['instance']) || $argument !== (array)$argument) {
132131
throw new \UnexpectedValueException(
133132
'Invalid parameter configuration provided for $' . $paramName . ' argument of ' . $requestedType
134133
);
135134
}
135+
$argumentType = $argument['instance'];
136136

137137
if (isset($argument['shared'])) {
138138
$isShared = $argument['shared'];

0 commit comments

Comments
 (0)