MAGETWO-59256: [GitHub] Custom composer modules break Component Manager #6718

Bohdan Korablov · Bohdan Korablov · commit e072d65045ce · 2016-10-05T15:31:52.000+03:00
diff --git a/setup/src/Magento/Setup/Model/PackagesData.php b/setup/src/Magento/Setup/Model/PackagesData.php
@@ -491,12 +491,10 @@ private function getPackageAvailableVersions($package)
                 $packageVersions = array_reverse($packageVersions);
 
                 return array_keys($packageVersions);
-            } else {
-                return $this->getPackageAvailableVersionByComposerCommand($package);
             }
-        } else {
-            return $this->getPackageAvailableVersionByComposerCommand($package);
         }
+
+        return $this->getAvailableVersionsFromAllRepositories($package);
     }
 
     /**
@@ -506,7 +504,7 @@ private function getPackageAvailableVersions($package)
      * @return array
      * @exception \RuntimeException
      */
-    private function getPackageAvailableVersionByComposerCommand($package)
+    private function getAvailableVersionsFromAllRepositories($package)
     {
         $versionsPattern = '/^versions\s*\:\s(.+)$/m';
 

Original file line number	Diff line number	Diff line change
`@@ -491,12 +491,10 @@ private function getPackageAvailableVersions($package)`
`491`	`491`	`$packageVersions = array_reverse($packageVersions);`
`492`	`492`
`493`	`493`	`return array_keys($packageVersions);`
`494`		`- } else {`
`495`		`- return $this->getPackageAvailableVersionByComposerCommand($package);`
`496`	`494`	`}`
`497`		`- } else {`
`498`		`- return $this->getPackageAvailableVersionByComposerCommand($package);`
`499`	`495`	`}`
	`496`	`+`
	`497`	`+ return $this->getAvailableVersionsFromAllRepositories($package);`
`500`	`498`	`}`
`501`	`499`
`502`	`500`	`/**`
`@@ -506,7 +504,7 @@ private function getPackageAvailableVersions($package)`
`506`	`504`	`* @return array`
`507`	`505`	`* @exception \RuntimeException`
`508`	`506`	`*/`
`509`		`- private function getPackageAvailableVersionByComposerCommand($package)`
	`507`	`+ private function getAvailableVersionsFromAllRepositories($package)`
`510`	`508`	`{`
`511`	`509`	`$versionsPattern = '/^versions\s*\:\s(.+)$/m';`
`512`	`510`