fixes for php 8.1 compatibility

Author: karyna-t

app/code/Magento/Catalog/Helper/Image.php

@@ -787,7 +787,7 @@ protected function getImageFile()
      */
     protected function parseSize($string)
     {
-        $size = explode('x', strtolower($string));
+        $size = $string ? explode('x', strtolower($string)) : [''];
         if (count($size) == 2) {
             return ['width' => $size[0] > 0 ? $size[0] : null, 'height' => $size[1] > 0 ? $size[1] : null];
         }

app/code/Magento/Catalog/Model/Category.php

@@ -852,7 +852,7 @@ public function getPathIds()
     {
         $ids = $this->getData('path_ids');
         if ($ids === null) {
-            $ids = explode('/', $this->getPath());
+            $ids = $this->getPath() ? explode('/', $this->getPath()) : [''];
             $this->setData('path_ids', $ids);
         }
         return $ids;
@@ -866,7 +866,7 @@ public function getPathIds()
     public function getLevel()
     {
         if (!$this->hasLevel()) {
-            return count(explode('/', $this->getPath())) - 1;
+            return $this->getPath() ? (count(explode('/', $this->getPath())) - 1) : 0;
         }
         return $this->getData(self::KEY_LEVEL);
     }

app/code/Magento/Catalog/Model/View/Asset/Image.php

@@ -201,8 +201,8 @@ public function getPath()
      */
     public function getSourceFile()
     {
-        return $this->mediaConfig->getBaseMediaPath()
-            . DIRECTORY_SEPARATOR . ltrim($this->getFilePath(), DIRECTORY_SEPARATOR);
+        $path = $this->getFilePath() ? ltrim($this->getFilePath(), DIRECTORY_SEPARATOR) : '';
+        return $this->mediaConfig->getBaseMediaPath() . DIRECTORY_SEPARATOR . $path;
     }
 
     /**

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php

@@ -561,7 +561,7 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
         if (false !== $value) {
             $optionValue = $this->getAttributeOptionValue($attributeId, $valueIds, $storeId);
             if (null === $optionValue) {
-                $value = $this->filterAttributeValue($value);
+                $value = ($value !== null) ? $this->filterAttributeValue($value) : '';
             } else {
                 $value = implode($this->separator, array_filter([$value, $optionValue]));
             }
@@ -581,7 +581,7 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
     private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
     {
         $optionKey = $attributeId . '-' . $storeId;
-        $attributeValueIds = explode(',', $valueIds);
+        $attributeValueIds = ($valueIds !== null) ? explode(',', $valueIds) : [''];
         $attributeOptionValue = '';
         if (!array_key_exists($optionKey, $this->attributeOptions)
         ) {
@@ -595,7 +595,7 @@ private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
                 $this->attributeOptions[$optionKey] = array_column($options, 'label', 'value');
                 $this->attributeOptions[$optionKey] = array_map(
                     function ($value) {
-                        return $this->filterAttributeValue($value);
+                        return ($value !== null) ? $this->filterAttributeValue($value) : '';
                     },
                     $this->attributeOptions[$optionKey]
                 );
@@ -618,7 +618,7 @@ function ($value) {
      * @param string $value
      * @return string
      */
-    private function filterAttributeValue($value)
+    private function filterAttributeValue(string $value)
     {
         return preg_replace('/\s+/iu', ' ', trim(strip_tags($value)));
     }

app/code/Magento/Indexer/Console/Command/IndexerReindexCommand.php

@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $resultTime = microtime(true) - $startTime;
 
                 $output->writeln(
-                    __('has been rebuilt successfully in %time', ['time' => gmdate('H:i:s', $resultTime)])
+                    __('has been rebuilt successfully in %time', ['time' => gmdate('H:i:s', (int) $resultTime)])
                 );
             } catch (\Throwable $e) {
                 $output->writeln('process error during indexation process:');

app/code/Magento/Quote/Model/Quote/Address.php

@@ -1452,6 +1452,9 @@ public function setCountryId($countryId)
     public function getStreet()
     {
         $street = $this->getData(self::KEY_STREET);
+        if (!$street) {
+            return [''];
+        }
         return is_array($street) ? $street : explode("\n", $street);
     }
 

app/code/Magento/Quote/Model/Quote/TotalsCollector.php

@@ -194,7 +194,7 @@ public function collect(\Magento\Quote\Model\Quote $quote)
     protected function _validateCouponCode(\Magento\Quote\Model\Quote $quote)
     {
         $code = $quote->getData('coupon_code');
-        if (strlen($code)) {
+        if ($code !== null && strlen($code)) {
             $addressHasCoupon = false;
             $addresses = $quote->getAllAddresses();
             if (count($addresses) > 0) {

app/code/Magento/Sales/Model/Order/Creditmemo.php

@@ -515,18 +515,8 @@ public function setShippingAmount($amount)
      */
     public function setAdjustmentPositive($amount)
     {
-        $amount = trim($amount);
-        if (substr($amount, -1) == '%') {
-            $amount = (double)substr($amount, 0, -1);
-            $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
-        }
-
-        $amount = $this->priceCurrency->round($amount);
-        $this->setData('base_adjustment_positive', $amount);
-
-        $amount = $this->priceCurrency->round($amount * $this->getOrder()->getBaseToOrderRate());
-        $this->setData('adjustment_positive', $amount);
-        return $this;
+        $amount = trim((string) $amount);
+        return $this->setAdjustmentAmount($amount, 'base_adjustment_positive', 'adjustment_positive');
     }
 
     /**
@@ -537,17 +527,30 @@ public function setAdjustmentPositive($amount)
      */
     public function setAdjustmentNegative($amount)
     {
-        $amount = trim($amount);
+        $amount = trim((string) $amount);
+        return $this->setAdjustmentAmount($amount, 'base_adjustment_negative', 'adjustment_negative');
+    }
+
+    /**
+     * Set adjustment amount.
+     *
+     * @param string $amount
+     * @param string $baseAdjustmentField
+     * @param string $adjustmentField
+     * @return $this
+     */
+    private function setAdjustmentAmount(string $amount, string $baseAdjustmentField, string $adjustmentField): self
+    {
         if (substr($amount, -1) == '%') {
-            $amount = (double)substr($amount, 0, -1);
+            $amount = (double) substr($amount, 0, -1);
             $amount = $this->getOrder()->getGrandTotal() * $amount / 100;
         }
 
         $amount = $this->priceCurrency->round($amount);
-        $this->setData('base_adjustment_negative', $amount);
+        $this->setData($baseAdjustmentField, $amount);
 
         $amount = $this->priceCurrency->round($amount * $this->getOrder()->getBaseToOrderRate());
-        $this->setData('adjustment_negative', $amount);
+        $this->setData($adjustmentField, $amount);
         return $this;
     }
 

app/code/Magento/SalesRule/Model/RulesApplier.php

@@ -153,7 +153,7 @@ public function addDiscountDescription($address, $rule)
         if ($ruleLabel) {
             $label = $ruleLabel;
         } else {
-            if (strlen($address->getCouponCode())) {
+            if ($address->getCouponCode() !== null && strlen($address->getCouponCode())) {
                 $label = $address->getCouponCode();
 
                 if ($rule->getDescription()) {

app/code/Magento/Tax/Model/ResourceModel/Calculation.php

@@ -233,7 +233,7 @@ protected function _createSearchPostCodeTemplates($postcode, $exactPostcode = nu
     {
         // as needed, reduce the postcode to the correct length
         $len = $this->_taxData->getPostCodeSubStringLength();
-        $postcode = substr($postcode, 0, $len);
+        $postcode = ($postcode !== null) ? substr($postcode, 0, $len) : '';
 
         // begin creating the search template array
         $strArr = [$postcode, $postcode . '*'];