MAGETWO-31422: XML file syntax error does not report file name error is in

Ivan Gavryshko · Ivan Gavryshko · commit dff94c9dcf15 · 2015-03-06T14:06:55.000-06:00
- fixed function to according to signature.
diff --git a/lib/internal/Magento/Framework/Xml/Parser.php b/lib/internal/Magento/Framework/Xml/Parser.php
@@ -182,10 +182,9 @@ public function loadXML($string)
      */
     public function errorHandler($errorNo, $errorStr, $errorFile, $errorLine)
     {
-        if ($errorNo == 0) {
-            return false;
+        if ($errorNo != 0) {
+            $message = "{$errorStr} in {$errorFile} on line {$errorLine}";
+            throw new \Magento\Framework\Exception($message);
         }
-        $message = "{$errorStr} in {$errorFile} on line {$errorLine}";
-        throw new \Magento\Framework\Exception($message);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -182,10 +182,9 @@ public function loadXML($string)`
`182`	`182`	`*/`
`183`	`183`	`public function errorHandler($errorNo, $errorStr, $errorFile, $errorLine)`
`184`	`184`	`{`
`185`		`- if ($errorNo == 0) {`
`186`		`- return false;`
	`185`	`+ if ($errorNo != 0) {`
	`186`	`+ $message = "{$errorStr} in {$errorFile} on line {$errorLine}";`
	`187`	`+ throw new \Magento\Framework\Exception($message);`
`187`	`188`	`}`
`188`		`- $message = "{$errorStr} in {$errorFile} on line {$errorLine}";`
`189`		`- throw new \Magento\Framework\Exception($message);`
`190`	`189`	`}`
`191`	`190`	`}`