Skip to content

Commit dfb6252

Browse files
committed
ACP2E-862: Cash on Delivery method is visible even if it is not allowed for that particular country
1 parent 4541e45 commit dfb6252

File tree

2 files changed

+15
-18
lines changed

2 files changed

+15
-18
lines changed

app/code/Magento/Checkout/Test/Mftf/Test/StorefrontCashOnDeliveryPaymentForSpecificCountryTest.xml

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<stories value="OnePageCheckout Cash on Delivery method disappears, if the address changed to the Country which is not allowed for it."/>
1616
<features value="OnePageCheckout"/>
1717
<severity value="AVERAGE"/>
18-
<testCaseId value=""/>
18+
<testCaseId value="AC-3216"/>
1919
<useCaseId value="ACP2E-862"/>
2020
<group value="checkout"/>
2121
</annotations>
@@ -27,7 +27,7 @@
2727
<magentoCLI command="config:set payment/cashondelivery/specificcountry GB" stepKey="specificCountryValue"/>
2828

2929
<!--Create Simple Product-->
30-
<createData entity="SimpleProduct2" stepKey="createSimpleProduct"/>
30+
<createData entity="SimpleProduct" stepKey="simpleProduct"/>
3131
<!--Create Customer-->
3232
<createData entity="Simple_US_Customer_US_UK_Addresses" stepKey="createCustomer"/>
3333
</before>
@@ -40,7 +40,7 @@
4040
<!--Customer log out-->
4141
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogout"/>
4242
<!--Delete created product-->
43-
<deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProduct"/>
43+
<deleteData createDataKey="simpleProduct" stepKey="deleteProduct"/>
4444
<!--Delete Customer-->
4545
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
4646
</after>
@@ -50,17 +50,13 @@
5050
<argument name="Customer" value="$$createCustomer$$"/>
5151
</actionGroup>
5252

53-
<!--Add Simple Product to cart-->
54-
<amOnPage url="{{StorefrontProductPage.url($$createSimpleProduct.custom_attributes[url_key]$$)}}" stepKey="navigateToSimpleProductPage"/>
55-
<waitForPageLoad stepKey="waitForSimpleProductPageLoad"/>
56-
<actionGroup ref="AddToCartFromStorefrontProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage">
57-
<argument name="productName" value="$$createSimpleProduct.name$$"/>
53+
<!--Add Simple Product to Shopping Cart and Proceed to checkout-->
54+
<amOnPage url="{{StorefrontProductPage.url($$simpleProduct.custom_attributes[url_key]$$)}}" stepKey="amOnSimpleProductPage"/>
55+
<actionGroup ref="StorefrontAddProductToCartActionGroup" stepKey="addProductToCart">
56+
<argument name="product" value="$$simpleProduct$$"/>
57+
<argument name="productCount" value="1"/>
5858
</actionGroup>
59-
60-
<!--Go to Cart and click 'Proceed To Checkout' button-->
61-
<actionGroup ref="StorefrontOpenCartFromMinicartActionGroup" stepKey="openCartPage"/>
62-
<actionGroup ref="StorefrontClickProceedToCheckoutActionGroup" stepKey="clickProceedToCheckout"/>
63-
<waitForElement selector="{{CheckoutShippingSection.shippingTab}}" stepKey="waitForCheckoutPage"/>
59+
<actionGroup ref="GoToCheckoutFromMinicartActionGroup" stepKey="goToCheckoutFromMinicart" />
6460

6561
<!-- Select Shipping Method-->
6662
<actionGroup ref="StorefrontSetShippingMethodActionGroup" stepKey="selectFlatRateShippingMethod"/>

app/code/Magento/Checkout/view/frontend/web/js/view/billing-address.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,13 @@ function (
124124
*/
125125
useShippingAddress: function () {
126126
if (this.isAddressSameAsShipping()) {
127+
addressUpadated = true;
128+
127129
selectBillingAddress(quote.shippingAddress());
130+
checkoutData.setSelectedBillingAddress(quote.shippingAddress().getKey());
131+
setBillingAddressAction(globalMessageList);
128132

129-
this.updateAddress();
133+
this.updateAddresses();
130134
this.isAddressDetailsVisible(true);
131135
} else {
132136
lastSelectedBillingAddress = quote.billingAddress();
@@ -146,10 +150,7 @@ function (
146150

147151
addressUpadated = true;
148152

149-
if (this.isAddressSameAsShipping()) {
150-
selectBillingAddress(quote.shippingAddress());
151-
checkoutData.setSelectedBillingAddress(quote.shippingAddress().getKey());
152-
} else if (this.selectedAddress() && !this.isAddressFormVisible()) {
153+
if (this.selectedAddress() && !this.isAddressFormVisible()) {
153154
selectBillingAddress(this.selectedAddress());
154155
checkoutData.setSelectedBillingAddress(this.selectedAddress().getKey());
155156
} else {

0 commit comments

Comments
 (0)