ENGCOM-5113: fix date calculation for report's years interval #22868

Author: sivaschenko

app/code/Magento/Reports/Model/ResourceModel/Report/Collection.php

@@ -12,6 +12,8 @@
 namespace Magento\Reports\Model\ResourceModel\Report;
 
 /**
+ * Class Collection
+ *
  * @api
  * @since 100.0.2
  */
@@ -100,6 +102,7 @@ public function __construct(
 
     /**
      * Set period
+     *
      * @codeCoverageIgnore
      *
      * @param int $period
@@ -113,6 +116,7 @@ public function setPeriod($period)
 
     /**
      * Set interval
+     *
      * @codeCoverageIgnore
      *
      * @param \DateTimeInterface $fromDate
@@ -248,7 +252,7 @@ protected function _getYearInterval(\DateTime $dateStart, \DateTime $dateEnd, $f
             ? $this->_localeDate->convertConfigTimeToUtc($dateStart->format('Y-m-d 00:00:00'))
             : $this->_localeDate->convertConfigTimeToUtc($dateStart->format('Y-01-01 00:00:00'));
 
-        $interval['end'] = $dateStart->diff($dateEnd)->y == 0
+        $interval['end'] = $dateStart->format('Y') === $dateEnd->format('Y')
             ? $this->_localeDate->convertConfigTimeToUtc(
                 $dateStart->setDate($dateStart->format('Y'), $dateEnd->format('m'), $dateEnd->format('d'))
                     ->format('Y-m-d 23:59:59')
@@ -275,6 +279,7 @@ public function getPeriods()
 
     /**
      * Set store ids
+     *
      * @codeCoverageIgnore
      *
      * @param array $storeIds
@@ -288,6 +293,7 @@ public function setStoreIds($storeIds)
 
     /**
      * Get store ids
+     *
      * @codeCoverageIgnore
      *
      * @return array
@@ -309,6 +315,7 @@ public function getSize()
 
     /**
      * Set page size
+     *
      * @codeCoverageIgnore
      *
      * @param int $size
@@ -322,6 +329,7 @@ public function setPageSize($size)
 
     /**
      * Get page size
+     *
      * @codeCoverageIgnore
      *
      * @return int