Skip to content

Commit df203c7

Browse files
committed
Fixes for failed tests
1 parent adc798e commit df203c7

File tree

1 file changed

+4
-17
lines changed
  • app/code/Magento/Downloadable/Helper

1 file changed

+4
-17
lines changed

app/code/Magento/Downloadable/Helper/File.php

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
*/
66
namespace Magento\Downloadable\Helper;
77

8-
use Magento\Framework\App\ObjectManager;
98
use Magento\Framework\Exception\FileSystemException;
10-
use Magento\Framework\Filesystem\DriverInterface;
119
use Magento\Framework\App\Filesystem\DirectoryList;
1210
use Magento\Framework\Exception\LocalizedException;
1311
use Magento\MediaStorage\Model\File\Uploader;
@@ -25,11 +23,6 @@ class File extends \Magento\Framework\App\Helper\AbstractHelper
2523
*/
2624
protected $_coreFileStorageDatabase = null;
2725

28-
/**
29-
* @var DriverInterface
30-
*/
31-
private $driver;
32-
3326
/**
3427
* Filesystem object.
3528
*
@@ -49,15 +42,13 @@ class File extends \Magento\Framework\App\Helper\AbstractHelper
4942
* @param \Magento\MediaStorage\Helper\File\Storage\Database $coreFileStorageDatabase
5043
* @param \Magento\Framework\Filesystem $filesystem
5144
* @param array $mimeTypes
52-
* @param DriverInterface|null $driver
5345
* @throws FileSystemException
5446
*/
5547
public function __construct(
5648
\Magento\Framework\App\Helper\Context $context,
5749
\Magento\MediaStorage\Helper\File\Storage\Database $coreFileStorageDatabase,
5850
\Magento\Framework\Filesystem $filesystem,
59-
array $mimeTypes = [],
60-
DriverInterface $driver = null
51+
array $mimeTypes = []
6152
) {
6253
$this->_coreFileStorageDatabase = $coreFileStorageDatabase;
6354
$this->_filesystem = $filesystem;
@@ -68,8 +59,6 @@ public function __construct(
6859
self::$_mimeTypes[$key] = $value;
6960
}
7061
}
71-
$this->driver = $driver ?: ObjectManager::getInstance()
72-
->create(DriverInterface::class);
7362
}
7463

7564
/**
@@ -150,12 +139,10 @@ protected function _moveFileFromTmp($baseTmpPath, $basePath, $file)
150139
if (strrpos($file, '.tmp') == strlen($file) - 4) {
151140
$file = substr($file, 0, strlen($file) - 4);
152141
}
142+
// phpcs:ignore Magento2.Functions.DiscouragedFunction
153143

154-
$destFile = $this->driver->getParentDirectory(
155-
$file
156-
) . '/' . Uploader::getNewFileName(
157-
$this->getFilePath($basePath, $file)
158-
);
144+
$destFile = dirname($file) . '/'
145+
. Uploader::getNewFileName($this->getFilePath($basePath, $file));
159146

160147
$this->_coreFileStorageDatabase->copyFile(
161148
$this->getFilePath($baseTmpPath, $file),

0 commit comments

Comments
 (0)