B2B-1704: Add MFTF test for MC-38621

 - Cleaning up tax helpers

Author: dhaecker

app/code/Magento/AwsS3/Test/Mftf/Test/AdminAwsS3ExportTaxRatesTest.xml

@@ -11,7 +11,7 @@
     <test name="AdminAwsS3ExportTaxRatesTest" extends="AdminExportTaxRatesTest">
         <annotations>
             <features value="AwsS3"/>
-            <stories value="Export"/>
+            <stories value="Export Tax"/>
             <title value="S3 - Export Tax Rates"/>
             <description value="Sets S3 for file system. Exports tax rates from the System > Data Transfer > Import/Export Tax Rates page and
             validates contents in downloaded file. Note that MFTF cannot simply click export and have access to the file

app/code/Magento/Tax/Test/Mftf/Helper/TaxHelpers.php

@@ -7,10 +7,8 @@
 
 namespace Magento\Tax\Test\Mftf\Helper;
 
-use Facebook\WebDriver\Remote\RemoteWebDriver as FacebookWebDriver;
 use Facebook\WebDriver\WebDriverBy;
 use Magento\FunctionalTestingFramework\Helper\Helper;
-use Magento\FunctionalTestingFramework\Module\MagentoWebDriver;
 
 /**
  * Class for MFTF helpers for Tax module.
@@ -36,12 +34,11 @@ public function deleteAllSpecifiedTaxRuleRows(
         string $successMessageContainer
     ): void {
         try {
-            /** @var MagentoWebDriver $webDriver */
             $magentoWebDriver = $this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver');
-            /** @var FacebookWebDriver $webDriver */
-            $webDriver = $magentoWebDriver->webDriver;
+            $facebookWebDriver = $magentoWebDriver->webDriver;
+
             $magentoWebDriver->waitForPageLoad(30);
-            $rows = $webDriver->findElements(WebDriverBy::xpath($rowsToDelete));
+            $rows = $facebookWebDriver->findElements(WebDriverBy::xpath($rowsToDelete));
             while (!empty($rows)) {
                 $rows[0]->click();
                 $magentoWebDriver->waitForPageLoad(30);
@@ -52,7 +49,7 @@ public function deleteAllSpecifiedTaxRuleRows(
                 $magentoWebDriver->click($modalAcceptButton);
                 $magentoWebDriver->waitForPageLoad(60);
                 $magentoWebDriver->waitForText($successMessage, 10, $successMessageContainer);
-                $rows = $webDriver->findElements(WebDriverBy::xpath($rowsToDelete));
+                $rows = $facebookWebDriver->findElements(WebDriverBy::xpath($rowsToDelete));
             }
         } catch (\Exception $exception) {
             $this->fail($exception->getMessage());