Skip to content

Commit dedcfb8

Browse files
zakdmazakdma
committed
Merge remote-tracking branch 'origin/MC-24261' into 2.4-develop-pr21
2 parents d46ca6e + a38c352 commit dedcfb8

15 files changed

+596
-8
lines changed

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontProductPageCloseFullscreenGalleryActionGroup.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
-->
7+
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10+
<actionGroup name="StorefrontProductPageCloseFullscreenGalleryActionGroup">
11+
<annotations>
12+
<description>Closes a product image gallery full-screen page.</description>
13+
</annotations>
14+
15+
<click selector="{{StorefrontProductMediaSection.closeFullscreenImage}}" stepKey="closeFullScreenPage"/>
16+
<waitForPageLoad stepKey="waitsForCloseFullScreenPage"/>
17+
</actionGroup>
18+
</actionGroups>

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontProductPageOpenImageFullscreenActionGroup.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
-->
7+
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
9+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10+
<actionGroup name="StorefrontProductPageOpenImageFullscreenActionGroup">
11+
<annotations>
12+
<description>Finds image of the product in thumbnails and open a full-screen review.</description>
13+
</annotations>
14+
<arguments>
15+
<argument name="imageNumber" type="string" defaultValue="2"/>
16+
</arguments>
17+
18+
<waitForElementVisible selector="{{StorefrontProductMediaSection.fotoramaImageThumbnail(imageNumber)}}" stepKey="waitThumbnailAppears"/>
19+
<conditionalClick selector="{{StorefrontProductMediaSection.fotoramaImageThumbnail(imageNumber)}}" dependentSelector="{{StorefrontProductMediaSection.fotoramaImageThumbnailActive(imageNumber)}}" visible="false" stepKey="clickOnThumbnailImage"/>
20+
<click selector="{{StorefrontProductMediaSection.gallery}}" stepKey="openFullScreenPage"/>
21+
</actionGroup>
22+
</actionGroups>

‎app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,10 +394,6 @@
394394
<data key="used_for_sort_by">true</data>
395395
<requiredEntity type="FrontendLabel">ProductAttributeFrontendLabel</requiredEntity>
396396
</entity>
397-
<entity name="VisualSwatchProductAttribute" type="ProductAttribute">
398-
<data key="frontend_input">swatch_visual</data>
399-
<data key="attribute_code" unique="suffix">visual_swatch</data>
400-
</entity>
401397
<entity name="ProductColorAttribute" type="ProductAttribute">
402398
<data key="frontend_label">Color</data>
403399
<data key="attribute_code" unique="suffix">color_attr</data>

‎app/code/Magento/Catalog/Test/Mftf/Section/AdminProductImagesSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
<element name="modalOkBtn" type="button" selector="button.action-primary.action-accept"/>
1919
<element name="uploadProgressBar" type="text" selector=".uploader .file-row"/>
2020
<element name="productImagesToggleState" type="button" selector="[data-index='gallery'] > [data-state-collapsible='{{status}}']" parameterized="true"/>
21-
2221
<element name="nthProductImage" type="button" selector="#media_gallery_content > div:nth-child({{var}}) img.product-image" parameterized="true"/>
2322
<element name="nthRemoveImageBtn" type="button" selector="#media_gallery_content > div:nth-child({{var}}) button.action-remove" parameterized="true"/>
2423

‎app/code/Magento/Catalog/Test/Mftf/Section/StorefrontProductMediaSection.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="StorefrontProductMediaSection">
1212
<element name="gallerySpinner" type="block" selector="#maincontent .fotorama__spinner--show" />
13-
<element name="gallery" type="block" selector="[data-gallery-role='gallery']" />
13+
<element name="gallery" type="block" selector="[data-gallery-role='gallery']" timeout="30"/>
1414
<element name="productImage" type="text" selector="//*[@data-gallery-role='gallery' and not(contains(@class, 'fullscreen'))]//img[contains(@src, '{{filename}}') and not(contains(@class, 'full'))]" parameterized="true" />
1515
<element name="productImageFullscreen" type="text" selector="//*[@data-gallery-role='gallery' and contains(@class, 'fullscreen')]//img[contains(@src, '{{filename}}') and contains(@class, 'full')]" parameterized="true" />
1616
<element name="closeFullscreenImage" type="button" selector="//*[@data-gallery-role='gallery' and contains(@class, 'fullscreen')]//*[@data-gallery-role='fotorama__fullscreen-icon']" />
@@ -19,5 +19,8 @@
1919
<element name="productImageInFotorama" type="file" selector=".fotorama__nav__shaft img[src*='{{imageName}}']" parameterized="true"/>
2020
<element name="fotoramaPrevButton" type="button" selector="//*[@data-gallery-role='gallery']//*[@data-gallery-role='nav-wrap']//*[@data-gallery-role='arrow' and contains(@class, 'fotorama__thumb__arr--left')]"/>
2121
<element name="fotoramaNextButton" type="button" selector="//*[@data-gallery-role='gallery']//*[@data-gallery-role='nav-wrap']//*[@data-gallery-role='arrow' and contains(@class, 'fotorama__thumb__arr--right')]"/>
22+
<element name="fotoramaAnyMedia" type="text" selector=".fotorama__nav__shaft img"/>
23+
<element name="fotoramaImageThumbnail" type="block" selector="//div[contains(@class, 'fotorama__nav__shaft')]//div[contains(@class, 'fotorama__nav__frame--thumb')][{{imageNumber}}]" parameterized="true" timeout="30"/>
24+
<element name="fotoramaImageThumbnailActive" type="block" selector="//div[contains(@class, 'fotorama__nav__shaft')]//div[contains(@class, 'fotorama__nav__frame--thumb') and contains(@class, 'fotorama__active')][{{imageNumber}}]" parameterized="true" timeout="30"/>
2225
</section>
2326
</sections>

‎app/code/Magento/Catalog/Test/Mftf/Test/StoreFrontRecentlyViewedAtStoreViewLevelTest.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@
1212
<stories value="Recently Viewed Product"/>
1313
<title value="Recently Viewed Product at store view level"/>
1414
<description value="Recently Viewed Product should not be displayed on second store view, if configured as, Per Store View "/>
15-
<testCaseId value="MC-31877"/>
15+
<testCaseId value="MC-32112"/>
1616
<severity value="CRITICAL"/>
1717
<group value="catalog"/>
18+
<group value="WYSIWYGDisabled"/>
1819
</annotations>
1920
<before>
2021
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

0 commit comments

Comments
 (0)