Skip to content

Commit ded182b

Browse files
author
Sergii Kovalenko
committed
MAGETWO-87190: Test coverage for critical logic
1 parent f1083fd commit ded182b

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

dev/tests/integration/framework/Magento/TestFramework/Application.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,16 +451,26 @@ public function run()
451451
}
452452

453453
/**
454-
* Cleanup both the database and the file system
454+
* Create install dir for integration framework
455455
*
456456
* @return void
457457
*/
458-
public function cleanup()
458+
public function createInstallDir()
459459
{
460460
$this->_ensureDirExists($this->installDir);
461461
$this->_ensureDirExists($this->_configDir);
462462

463463
$this->copyAppConfigFiles();
464+
}
465+
466+
/**
467+
* Cleanup both the database and the file system
468+
*
469+
* @return void
470+
*/
471+
public function cleanup()
472+
{
473+
$this->createInstallDir();
464474
/**
465475
* @see \Magento\Setup\Mvc\Bootstrap\InitParamListener::BOOTSTRAP_PARAM
466476
*/

dev/tests/setup-integration/framework/bootstrap.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
new \Magento\TestFramework\Bootstrap\MemoryFactory($shell)
7575
);
7676
$bootstrap->runBootstrap();
77-
$application->cleanup();
77+
$application->createInstallDir();
7878
//remove test modules files
7979
include_once __DIR__ . '/../../setup-integration/framework/removeTestModules.php';
8080
//We do not want to install anything

lib/internal/Magento/Framework/Shell.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,8 @@ public function execute($command, array $arguments = [])
5656

5757
exec($command, $output, $exitCode);
5858
$output = implode(PHP_EOL, $output);
59-
var_dump($command);
60-
var_dump($output);
6159
$this->log($output);
60+
6261
if ($exitCode) {
6362
$commandError = new \Exception($output, $exitCode);
6463
throw new Exception\LocalizedException(

0 commit comments

Comments
 (0)