Skip to content

Commit ddb09f9

Browse files
author
Oleksii Korshenko
authored
MAGETWO-70797: Use backend model also for default config values #7742
2 parents 929a852 + 59341a0 commit ddb09f9

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

app/code/Magento/Config/Block/System/Config/Form.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -427,21 +427,21 @@ private function getFieldData(\Magento\Config\Model\Config\Structure\Element\Fie
427427
if ($data === null) {
428428
if (array_key_exists($path, $this->_configData)) {
429429
$data = $this->_configData[$path];
430-
431-
if ($field->hasBackendModel()) {
432-
$backendModel = $field->getBackendModel();
433-
$backendModel->setPath($path)
434-
->setValue($data)
435-
->setWebsite($this->getWebsiteCode())
436-
->setStore($this->getStoreCode())
437-
->afterLoad();
438-
$data = $backendModel->getValue();
439-
}
440430
} elseif ($field->getConfigPath() !== null) {
441431
$data = $this->getConfigValue($field->getConfigPath());
442432
} else {
443433
$data = $this->getConfigValue($path);
444434
}
435+
436+
if ($field->hasBackendModel()) {
437+
$backendModel = $field->getBackendModel();
438+
$backendModel->setPath($path)
439+
->setValue($data)
440+
->setWebsite($this->getWebsiteCode())
441+
->setStore($this->getStoreCode())
442+
->afterLoad();
443+
$data = $backendModel->getValue();
444+
}
445445
}
446446

447447
return $data;

app/code/Magento/Config/Test/Unit/Block/System/Config/FormTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ public function initFieldsDataProvider()
676676
true,
677677
'Config Value',
678678
null,
679-
0,
679+
1,
680680
true,
681681
false,
682682
true

dev/tests/integration/testsuite/Magento/PageCache/Model/ConfigTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ protected function setUp()
6363
'accessList' => explode(',', '127.0.0.1,192.168.0.1,127.0.0.2'),
6464
'designExceptions' => json_decode('{"_":{"regexp":"\/firefox\/i","value":"Magento\/blank"}}', true),
6565
'sslOffloadedHeader' => 'X-Forwarded-Proto',
66-
'gracePeriod' => null
66+
'gracePeriod' => 1234
6767
];
6868
$vclGeneratorFactory->expects($this->any())
6969
->method('create')
@@ -73,7 +73,7 @@ protected function setUp()
7373
'example.com',
7474
'8080',
7575
explode(',', '127.0.0.1,192.168.0.1,127.0.0.2'),
76-
null,
76+
1234,
7777
'X-Forwarded-Proto',
7878
json_decode('{"_":{"regexp":"\/firefox\/i","value":"Magento\/blank"}}', true)
7979
)));
@@ -89,6 +89,7 @@ protected function setUp()
8989
/**
9090
* @magentoConfigFixture default/system/full_page_cache/varnish/backend_host example.com
9191
* @magentoConfigFixture default/system/full_page_cache/varnish/backend_port 8080
92+
* @magentoConfigFixture default/system/full_page_cache/varnish/grace_period 1234
9293
* @magentoConfigFixture default/system/full_page_cache/varnish/access_list 127.0.0.1,192.168.0.1,127.0.0.2
9394
* @magentoConfigFixture current_store design/theme/ua_regexp {"_":{"regexp":"\/firefox\/i","value":"Magento\/blank"}}
9495
* @magentoAppIsolation enabled

0 commit comments

Comments
 (0)