Skip to content

Commit dd744f3

Browse files
committed
MC-41896: Fix jQuery submit calls
1 parent e83f00d commit dd744f3

File tree

7 files changed

+12
-15
lines changed

7 files changed

+12
-15
lines changed

app/code/Magento/Catalog/view/adminhtml/web/catalog/product/composite/configure.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ define([
365365
if (Object.isFunction(this.beforeSubmitCallback[this.current.listType])) {
366366
this.beforeSubmitCallback[this.current.listType]();
367367
}
368-
this.blockForm.trigger('submit');
368+
this.blockForm.submit();
369369

370370
// Show loader
371371
jQuery(this.blockForm).trigger('processStart');

app/code/Magento/ImportExport/view/adminhtml/templates/export/form/before.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ require([
8989
url += '/fields_enclosure/' + \$F('fields_enclosure');
9090
}
9191
form.action = url;
92-
form.trigger('submit');
92+
form.submit();
9393
form.action = oldAction;
9494
} else {
9595
alert({

app/code/Magento/Newsletter/view/adminhtml/templates/preview/iframeswitcher.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ var previewIframe = $('preview_iframe');
3939
function preview() {
4040
previewForm.writeAttribute('target', previewIframe.readAttribute('id'));
4141
blockPreview();
42-
previewForm.trigger('submit');
42+
previewForm.submit();
4343
}
4444
4545
function blockPreview() {

app/code/Magento/Paypal/view/frontend/web/js/paypal-checkout.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,11 @@ define([
8989
}
9090
$(ppCheckoutInput).val(returnUrl);
9191

92-
$form.trigger('submit');
92+
if ($form instanceof jQuery) {
93+
$form.trigger('submit');
94+
} else {
95+
$form.submit();
96+
}
9397
} else {
9498
$.mage.redirect(returnUrl);
9599
}

app/code/Magento/Swatches/view/adminhtml/web/js/form/element/swatch-visual.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ define([
165165

166166
/**
167167
* form component for upload image
168-
* @type {jQuery}
169168
*/
170169
form: null,
171170

@@ -242,7 +241,7 @@ define([
242241

243242
swatchComponents.iframe.off('load');
244243
swatchComponents.iframe.load(iframeHandler);
245-
swatchComponents.form.trigger('submit');
244+
swatchComponents.form.submit();
246245
$(this).val('');
247246
});
248247

app/code/Magento/Swatches/view/adminhtml/web/js/visual.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ define([
299299

300300
/**
301301
* form component for upload image
302-
* @type {jQuery}
303302
*/
304303
form: null,
305304

@@ -376,7 +375,7 @@ define([
376375

377376
swatchComponents.iframe.off('load');
378377
swatchComponents.iframe.load(iframeHandler);
379-
swatchComponents.form.trigger('submit');
378+
swatchComponents.form.submit();
380379
$(this).val('');
381380
});
382381

lib/web/mage/adminhtml/grid.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ define([
420420
form.append(input);
421421
});
422422
jQuery('[data-container="body"]').append(form);
423-
form.trigger('submit');
423+
form.submit();
424424
form.remove();
425425
},
426426

@@ -1155,12 +1155,7 @@ define([
11551155
});
11561156
} else if (item.url) {
11571157
this.form.action = item.url;
1158-
1159-
if (this.form instanceof jQuery) {
1160-
this.form.trigger('submit');
1161-
} else {
1162-
this.form.submit();
1163-
}
1158+
this.form.submit();
11641159
}
11651160
},
11661161

0 commit comments

Comments
 (0)