MAGETWO-92164: [Backport for 2.1.x] Redundancy in Custom Option Filenames

Oleksandr Gorkun · Oleksandr Gorkun · commit dd70606a71e6 · 2018-06-06T11:56:50.000+03:00
diff --git a/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php b/app/code/Magento/Catalog/Model/Product/Option/Type/File/ValidatorFile.php
@@ -91,7 +91,7 @@ public function __construct(
         $this->httpFactory = $httpFactory;
         $this->isImageValidator = $isImageValidator;
         $this->random = $random
-            ?? ObjectManager::getInstance()->get(Random::class);
+            ? $random : ObjectManager::getInstance()->get(Random::class);
         parent::__construct($scopeConfig, $filesystem, $fileSize);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ public function __construct(`
`91`	`91`	`$this->httpFactory = $httpFactory;`
`92`	`92`	`$this->isImageValidator = $isImageValidator;`
`93`	`93`	`$this->random = $random`
`94`		`- ?? ObjectManager::getInstance()->get(Random::class);`
	`94`	`+ ? $random : ObjectManager::getInstance()->get(Random::class);`
`95`	`95`	`parent::__construct($scopeConfig, $filesystem, $fileSize);`
`96`	`96`	`}`
`97`	`97`