Skip to content

Commit dd58184

Browse files
magento-engcom-teammagento-engcom-team
authored
🔃 [EngCom] Public Pull Requests - 2.2-develop
Accepted Public Pull Requests: - #17454: Braintree: test coverage (by @dmytro-ch) - #16753: Fix the issue with "Shipping address is not set" exception (by @dmytro-ch) - #15507: fix: cache count() results for loops (by @DanielRuf) Fixed GitHub Issues: - #16555: "Shipping address is not set" exception in Multishipping Checkout. (reported by @p-bystritsky) has been fixed in #16753 by @dmytro-ch in 2.2-develop branch Related commits: 1. def9a82 2. 4268a75 3. 9a47c0e 4. 6f88af5 5. cc44078 6. 75c3a2e
2 parents adc6c00 + e934ced commit dd58184

File tree

21 files changed

+377
-22
lines changed

21 files changed

+377
-22
lines changed

‎app/code/Magento/Braintree/Test/Unit/Model/InstantPurchase/CreditCard/AvailabilityCheckerTest.php

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Braintree\Test\Unit\Model\InstantPurchase\CreditCard;
9+
10+
use Magento\Braintree\Gateway\Config\Config;
11+
use Magento\Braintree\Model\InstantPurchase\CreditCard\AvailabilityChecker;
12+
13+
/**
14+
* @covers \Magento\Braintree\Model\InstantPurchase\CreditCard\AvailabilityChecker
15+
*/
16+
class AvailabilityCheckerTest extends \PHPUnit\Framework\TestCase
17+
{
18+
/**
19+
* Testable Object
20+
*
21+
* @var AvailabilityChecker
22+
*/
23+
private $availabilityChecker;
24+
25+
/**
26+
* @var Config|\PHPUnit_Framework_MockObject_MockObject
27+
*/
28+
private $configMock;
29+
30+
/**
31+
* Set Up
32+
*
33+
* @return void
34+
*/
35+
protected function setUp()
36+
{
37+
$this->configMock = $this->createMock(Config::class);
38+
$this->availabilityChecker = new AvailabilityChecker($this->configMock);
39+
}
40+
41+
/**
42+
* Test isAvailable method
43+
*
44+
* @dataProvider isAvailableDataProvider
45+
*
46+
* @param bool $isVerify3DSecure
47+
* @param bool $expected
48+
*
49+
* @return void
50+
*/
51+
public function testIsAvailable(bool $isVerify3DSecure, bool $expected)
52+
{
53+
$this->configMock->expects($this->once())->method('isVerify3DSecure')->willReturn($isVerify3DSecure);
54+
$actual = $this->availabilityChecker->isAvailable();
55+
self::assertEquals($expected, $actual);
56+
}
57+
58+
/**
59+
* Data provider for isAvailable method test
60+
*
61+
* @return array
62+
*/
63+
public function isAvailableDataProvider()
64+
{
65+
return [
66+
[true, false],
67+
[false, true],
68+
];
69+
}
70+
}

‎app/code/Magento/Braintree/Test/Unit/Model/InstantPurchase/PaymentAdditionalInformationProviderTest.php

Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Braintree\Test\Unit\Model\InstantPurchase;
9+
10+
use Magento\Braintree\Gateway\Command\GetPaymentNonceCommand;
11+
use Magento\Braintree\Model\InstantPurchase\PaymentAdditionalInformationProvider;
12+
use Magento\Payment\Gateway\Command\Result\ArrayResult;
13+
use Magento\Vault\Api\Data\PaymentTokenInterface;
14+
15+
/**
16+
* @covers \Magento\Braintree\Model\InstantPurchase\PaymentAdditionalInformationProvider
17+
*/
18+
class PaymentAdditionalInformationProviderTest extends \PHPUnit\Framework\TestCase
19+
{
20+
/**
21+
* Testable Object
22+
*
23+
* @var PaymentAdditionalInformationProvider
24+
*/
25+
private $paymentAdditionalInformationProvider;
26+
27+
/**
28+
* @var GetPaymentNonceCommand|\PHPUnit_Framework_MockObject_MockObject
29+
*/
30+
private $getPaymentNonceCommandMock;
31+
32+
/**
33+
* @var PaymentTokenInterface|\PHPUnit_Framework_MockObject_MockObject
34+
*/
35+
private $paymentTokenMock;
36+
37+
/**
38+
* @var ArrayResult|\PHPUnit_Framework_MockObject_MockObject
39+
*/
40+
private $arrayResultMock;
41+
42+
/**
43+
* Set Up
44+
*
45+
* @return void
46+
*/
47+
protected function setUp()
48+
{
49+
$this->getPaymentNonceCommandMock = $this->createMock(GetPaymentNonceCommand::class);
50+
$this->paymentTokenMock = $this->createMock(PaymentTokenInterface::class);
51+
$this->arrayResultMock = $this->createMock(ArrayResult::class);
52+
$this->paymentAdditionalInformationProvider = new PaymentAdditionalInformationProvider(
53+
$this->getPaymentNonceCommandMock
54+
);
55+
}
56+
57+
/**
58+
* Test getAdditionalInformation method
59+
*
60+
* @return void
61+
*/
62+
public function testGetAdditionalInformation()
63+
{
64+
$customerId = 15;
65+
$publicHash = '3n4b7sn48g';
66+
$paymentMethodNonce = 'test';
67+
68+
$this->paymentTokenMock->expects($this->once())->method('getCustomerId')->willReturn($customerId);
69+
$this->paymentTokenMock->expects($this->once())->method('getPublicHash')->willReturn($publicHash);
70+
$this->getPaymentNonceCommandMock->expects($this->once())->method('execute')->with([
71+
PaymentTokenInterface::CUSTOMER_ID => $customerId,
72+
PaymentTokenInterface::PUBLIC_HASH => $publicHash,
73+
])->willReturn($this->arrayResultMock);
74+
$this->arrayResultMock->expects($this->once())->method('get')
75+
->willReturn(['paymentMethodNonce' => $paymentMethodNonce]);
76+
77+
$expected = [
78+
'payment_method_nonce' => $paymentMethodNonce,
79+
];
80+
$actual = $this->paymentAdditionalInformationProvider->getAdditionalInformation($this->paymentTokenMock);
81+
self::assertEquals($expected, $actual);
82+
}
83+
}

‎app/code/Magento/Braintree/Test/Unit/Model/LocaleResolverTest.php

Lines changed: 138 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,138 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Braintree\Test\Unit\Model;
9+
10+
use Magento\Braintree\Gateway\Config\PayPal\Config;
11+
use Magento\Braintree\Model\LocaleResolver;
12+
use Magento\Framework\Locale\ResolverInterface;
13+
14+
/**
15+
* @covers \Magento\Braintree\Model\LocaleResolver
16+
*/
17+
class LocaleResolverTest extends \PHPUnit\Framework\TestCase
18+
{
19+
/**
20+
* Testable Object
21+
*
22+
* @var LocaleResolver
23+
*/
24+
private $localeResolver;
25+
26+
/**
27+
* @var Config|\PHPUnit_Framework_MockObject_MockObject
28+
*/
29+
private $configMock;
30+
31+
/**
32+
* @var ResolverInterface|\PHPUnit_Framework_MockObject_MockObject
33+
*/
34+
private $resolverMock;
35+
36+
/**
37+
* Set Up
38+
*
39+
* @return void
40+
*/
41+
protected function setUp()
42+
{
43+
$this->configMock = $this->createMock(Config::class);
44+
$this->resolverMock = $this->createMock(ResolverInterface::class);
45+
$this->localeResolver = new LocaleResolver($this->resolverMock, $this->configMock);
46+
}
47+
48+
/**
49+
* Test getDefaultLocalePath method
50+
*
51+
* @return void
52+
*/
53+
public function testGetDefaultLocalePath()
54+
{
55+
$expected = 'general/locale/code';
56+
$this->resolverMock->expects($this->once())->method('getDefaultLocalePath')->willReturn($expected);
57+
$actual = $this->localeResolver->getDefaultLocalePath();
58+
self::assertEquals($expected, $actual);
59+
}
60+
61+
/**
62+
* Test setDefaultLocale method
63+
*
64+
* @return void
65+
*/
66+
public function testSetDefaultLocale()
67+
{
68+
$defaultLocale = 'en_US';
69+
$this->resolverMock->expects($this->once())->method('setDefaultLocale')->with($defaultLocale);
70+
$this->localeResolver->setDefaultLocale($defaultLocale);
71+
}
72+
73+
/**
74+
* Test getDefaultLocale method
75+
*
76+
* @return void
77+
*/
78+
public function testGetDefaultLocale()
79+
{
80+
$expected = 'fr_FR';
81+
$this->resolverMock->expects($this->once())->method('getDefaultLocale')->willReturn($expected);
82+
$actual = $this->localeResolver->getDefaultLocale();
83+
self::assertEquals($expected, $actual);
84+
}
85+
86+
/**
87+
* Test setLocale method
88+
*
89+
* @return void
90+
*/
91+
public function testSetLocale()
92+
{
93+
$locale = 'en_GB';
94+
$this->resolverMock->expects($this->once())->method('setLocale')->with($locale);
95+
$this->localeResolver->setLocale($locale);
96+
}
97+
98+
/**
99+
* Test getLocale method
100+
*
101+
* @return void
102+
*/
103+
public function testGetLocale()
104+
{
105+
$locale = 'en_TEST';
106+
$allowedLocales = 'en_US,en_GB,en_AU,da_DK,fr_FR,fr_CA,de_DE,zh_HK,it_IT,nl_NL';
107+
$this->resolverMock->expects($this->once())->method('getLocale')->willReturn($locale);
108+
$this->configMock->expects($this->once())->method('getValue')->with('supported_locales')
109+
->willReturn($allowedLocales);
110+
111+
$expected = 'en_US';
112+
$actual = $this->localeResolver->getLocale();
113+
self::assertEquals($expected, $actual);
114+
}
115+
116+
/**
117+
* Test emulate method
118+
*
119+
* @return void
120+
*/
121+
public function testEmulate()
122+
{
123+
$scopeId = 12;
124+
$this->resolverMock->expects($this->once())->method('emulate')->with($scopeId);
125+
$this->localeResolver->emulate($scopeId);
126+
}
127+
128+
/**
129+
* Test revert method
130+
*
131+
* @return void
132+
*/
133+
public function testRevert()
134+
{
135+
$this->resolverMock->expects($this->once())->method('revert');
136+
$this->localeResolver->revert();
137+
}
138+
}

‎app/code/Magento/Multishipping/Controller/Checkout.php

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use Magento\Customer\Api\AccountManagementInterface;
99
use Magento\Customer\Api\CustomerRepositoryInterface;
1010
use Magento\Framework\App\RequestInterface;
11+
use Magento\Framework\Exception\StateException;
1112

1213
/**
1314
* Multishipping checkout controller
@@ -84,6 +85,7 @@ protected function _getCheckoutSession()
8485
*
8586
* @param RequestInterface $request
8687
* @return \Magento\Framework\App\ResponseInterface
88+
* @throws \Magento\Framework\Exception\NotFoundException
8789
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
8890
* @SuppressWarnings(PHPMD.NPathComplexity)
8991
*/
@@ -152,7 +154,15 @@ public function dispatch(RequestInterface $request)
152154
return parent::dispatch($request);
153155
}
154156

155-
$quote = $this->_getCheckout()->getQuote();
157+
try {
158+
$checkout = $this->_getCheckout();
159+
} catch (StateException $e) {
160+
$this->getResponse()->setRedirect($this->_getHelper()->getMSNewShippingUrl());
161+
$this->_actionFlag->set('', self::FLAG_NO_DISPATCH, true);
162+
return parent::dispatch($request);
163+
}
164+
165+
$quote = $checkout->getQuote();
156166
if (!$quote->hasItems() || $quote->getHasError() || $quote->isVirtual()) {
157167
$this->getResponse()->setRedirect($this->_getHelper()->getCartUrl());
158168
$this->_actionFlag->set('', self::FLAG_NO_DISPATCH, true);

‎app/code/Magento/Multishipping/Helper/Url.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,16 @@ public function getMSShippingAddressSavedUrl()
6363
return $this->_getUrl('multishipping/checkout_address/shippingSaved');
6464
}
6565

66+
/**
67+
* Retrieve register url
68+
*
69+
* @return string
70+
*/
71+
public function getMSNewShippingUrl()
72+
{
73+
return $this->_getUrl('multishipping/checkout_address/newShipping');
74+
}
75+
6676
/**
6777
* Retrieve register url
6878
*

‎app/code/Magento/Paypal/Model/Report/Settlement.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,8 @@ public function parseCsv($localCsv, $format = 'new')
416416
private function getBodyItems(array $line, array $sectionColumns, array $rowMap)
417417
{
418418
$bodyItem = [];
419-
for ($i = 1, $count = count($line); $i < $count; $i++) {
419+
$lineCount = count($line);
420+
for ($i = 1, $count = $lineCount; $i < $count; $i++) {
420421
if(isset($rowMap[$sectionColumns[$i]])) {
421422
if (in_array($rowMap[$sectionColumns[$i]], $this->dateTimeColumns)) {
422423
$line[$i] = $this->formatDateTimeColumns($line[$i]);

0 commit comments

Comments
 (0)