MC-32014: Remove google-shopping-ads module from core in 2.4.1

Author: krissyhiserote

dev/tests/setup-integration/framework/bootstrap.php

@@ -102,6 +102,8 @@
     /* Unset declared global variables to release the PHPUnit from maintaining their values between tests */
     unset($testsBaseDir, $logWriter, $settings, $shell, $application, $bootstrap);
 } catch (\Exception $e) {
+    // phpcs:disable Magento2.Security.LanguageConstruct
     echo $e . PHP_EOL;
     exit(1);
+    // phpcs:enable Magento2.Security.LanguageConstruct
 }

lib/internal/Magento/Framework/Mview/Test/Unit/View/CollectionTest.php

@@ -143,6 +143,15 @@ function ($elem) {
                 $indexers
             ));
 
+        $this->mviewConfigMock
+            ->method('getView')
+            ->willReturnMap(array_map(
+                function ($elem) {
+                    return [$elem, ['view_id' => $elem]];
+                },
+                $views
+            ));
+
         $this->entityFactoryMock
             ->method('create')
             ->willReturnMap([

setup/src/Magento/Setup/Model/Installer.php

@@ -995,6 +995,7 @@ private function throwExceptionForNotWritablePaths(array $paths)
     private function handleDBSchemaData($setup, $type, array $request)
     {
         if (!($type === 'schema' || $type === 'data')) {
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
             throw  new Exception("Unsupported operation type $type is requested");
         }
         $resource = new \Magento\Framework\Module\ModuleResource($this->context);
@@ -1117,6 +1118,7 @@ private function assertDbConfigExists()
     {
         $config = $this->deploymentConfig->get(ConfigOptionsListConstants::CONFIG_PATH_DB_CONNECTION_DEFAULT);
         if (!$config) {
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new Exception(
                 "Can't run this operation: configuration for DB connection is absent."
             );
@@ -1193,6 +1195,7 @@ protected function createSchemaDataHandler($className, $interfaceName)
     {
         if (class_exists($className)) {
             if (!is_subclass_of($className, $interfaceName) && $className !== $interfaceName) {
+                // phpcs:ignore Magento2.Exceptions.DirectThrow
                 throw  new Exception($className . ' must implement \\' . $interfaceName);
             } else {
                 return $this->objectManagerProvider->get()->create($className);
@@ -1282,6 +1285,7 @@ public function updateModulesSequence($keepGeneratedFiles = false)
     {
         $config = $this->deploymentConfig->get(ConfigOptionsListConstants::KEY_MODULES);
         if (!$config) {
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new Exception(
                 "Can't run this operation: deployment configuration is absent."
                 . " Run 'magento setup:config:set --help' for options."
@@ -1579,6 +1583,7 @@ private function getSchemaDataHandler($moduleName, $type)
                 $interface = self::DATA_INSTALL;
                 break;
             default:
+                // phpcs:ignore Magento2.Exceptions.DirectThrow
                 throw new Exception("$className does not exist");
         }
 
@@ -1602,6 +1607,7 @@ private function generateListOfModuleContext($resource, $type)
             } elseif ($type === 'data-version') {
                 $dbVer = $resource->getDataVersion($moduleName);
             } else {
+                // phpcs:ignore Magento2.Exceptions.DirectThrow
                 throw  new Exception("Unsupported version type $type is requested");
             }
             if ($dbVer !== false) {