Skip to content

Commit dc7d455

Browse files
committed
MAGETWO-87776: Build stabilization
-fix architects comments
1 parent c1bce41 commit dc7d455

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

app/code/Magento/Catalog/Model/ResourceModel/Eav/Attribute.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,10 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements
105105
* @param \Magento\Catalog\Model\Indexer\Product\Eav\Processor $indexerEavProcessor
106106
* @param \Magento\Catalog\Helper\Product\Flat\Indexer $productFlatIndexerHelper
107107
* @param LockValidatorInterface $lockValidator
108-
* @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource
109-
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
108+
* @param \Magento\Framework\Model\ResourceModel\AbstractResource|null $resource
109+
* @param \Magento\Framework\Data\Collection\AbstractDb|null $resourceCollection
110110
* @param array $data
111+
* @param \Magento\Eav\Api\Data\AttributeExtensionFactory|null $eavAttributeFactory
111112
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
112113
*/
113114
public function __construct(
@@ -133,8 +134,8 @@ public function __construct(
133134
LockValidatorInterface $lockValidator,
134135
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
135136
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
136-
\Magento\Eav\Api\Data\AttributeExtensionFactory $eavAttributeFactory = null,
137-
array $data = []
137+
array $data = [],
138+
\Magento\Eav\Api\Data\AttributeExtensionFactory $eavAttributeFactory = null
138139
) {
139140
$this->_indexerEavProcessor = $indexerEavProcessor;
140141
$this->_productFlatIndexerProcessor = $productFlatIndexerProcessor;

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav/CompositeConfigProcessor.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ public function __construct(Logger $logger, array $eavWysiwygDataProcessors)
3333
}
3434

3535
/**
36-
* @param \Magento\Catalog\Api\Data\ProductAttributeInterface $attribute
37-
* @return array
36+
* {@inheritdoc}
3837
*/
3938
public function process(\Magento\Catalog\Api\Data\ProductAttributeInterface $attribute)
4039
{
@@ -44,7 +43,7 @@ public function process(\Magento\Catalog\Api\Data\ProductAttributeInterface $att
4443
if (!$processor instanceof WysiwygConfigDataProcessorInterface) {
4544
$this->logger->critical(
4645
__(
47-
'Processor %1 doesn\'t implement BaseSelectProcessorInterface. It will be skipped',
46+
'Processor %1 doesn\'t implement WysiwygConfigDataProcessorInterface. It will be skipped',
4847
get_class($processor)
4948
)
5049
);

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav/WysiwygConfigDataProcessor.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
class WysiwygConfigDataProcessor implements WysiwygConfigDataProcessorInterface
1515
{
1616
/**
17-
* @param \Magento\Catalog\Api\Data\ProductAttributeInterface $attribute
18-
* @return array
19-
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
17+
* {@inheritdoc}
2018
*/
2119
public function process(\Magento\Catalog\Api\Data\ProductAttributeInterface $attribute)
2220
{

0 commit comments

Comments
 (0)