Skip to content

Commit dc5c3fb

Browse files
committed
ACP2E-3867: Missing validation for Catalog Price rule discount amount field
1 parent 7a266df commit dc5c3fb

File tree

1 file changed

+45
-0
lines changed
  • dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/lib/validation

1 file changed

+45
-0
lines changed

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/lib/validation/rules.test.js

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,51 @@ define([
119119
expect(rules['validate-nonempty-number-greater-than-zero'].handler(value)).toBe(false);
120120
});
121121
});
122+
describe('"validate-number-range" method', function () {
123+
it('should return true for empty value', function () {
124+
expect(rules['validate-number-range'].handler('', '1-10')).toBe(true);
125+
});
126+
127+
it('should return true for value within range', function () {
128+
expect(rules['validate-number-range'].handler('5', '1-10')).toBe(true);
129+
});
130+
131+
it('should return false for value below range', function () {
132+
expect(rules['validate-number-range'].handler('0', '1-10')).toBe(false);
133+
});
134+
135+
it('should return false for value above range', function () {
136+
expect(rules['validate-number-range'].handler('11', '1-10')).toBe(false);
137+
});
138+
139+
it('should return false for non-numeric value', function () {
140+
expect(rules['validate-number-range'].handler('abc', '1-10')).toBe(false);
141+
});
142+
143+
it('should return true for value equal to min', function () {
144+
expect(rules['validate-number-range'].handler('1', '1-10')).toBe(true);
145+
});
146+
147+
it('should return true for value equal to max', function () {
148+
expect(rules['validate-number-range'].handler('10', '1-10')).toBe(true);
149+
});
150+
151+
it('should return true for value within negative range', function () {
152+
expect(rules['validate-number-range'].handler('-5', '-10--1')).toBe(true);
153+
});
154+
155+
it('should return false for value outside negative range', function () {
156+
expect(rules['validate-number-range'].handler('0', '-10--1')).toBe(false);
157+
});
158+
159+
it('should return false for invalid range param', function () {
160+
expect(rules['validate-number-range'].handler('5', 'invalid')).toBe(false);
161+
});
162+
163+
it('should return false for alphanumeric value', function () {
164+
expect(rules['validate-number-range'].handler('abc123', '1-10')).toBe(false);
165+
});
166+
});
122167
});
123168

124169
describe('validate-color', function () {

0 commit comments

Comments
 (0)