MC-20425: [Integration Test] Check behavior when attribute set was changed to a new set with deleted attribute from the previous set

Author: zakdma

dev/tests/integration/testsuite/Magento/Catalog/Controller/Product/ViewTest.php

@@ -7,20 +7,21 @@
 
 namespace Magento\Catalog\Controller\Product;
 
+use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Product;
 use Magento\Eav\Model\AttributeSetSearchResults;
 use Magento\Eav\Model\Entity\Attribute\Set;
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Framework\Api\SortOrderBuilder;
-use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Data\Collection;
 use Magento\Catalog\Api\AttributeSetRepositoryInterface;
 use Magento\Eav\Model\Entity\Type;
-use Magento\Framework\Filesystem;
-use Magento\Framework\Filesystem\Directory\WriteInterface;
-use Magento\Framework\Filesystem\File\WriteInterface as FileWriteInterface;
-use Magento\Framework\Filesystem\Driver\File;
+use PHPUnit\Framework\MockObject\MockObject;
+use Psr\Log\LoggerInterface;
+use Magento\Catalog\Api\Data\ProductAttributeInterface;
+use Magento\Catalog\Api\ProductAttributeRepositoryInterface;
+use Magento\Framework\Logger\Monolog as MagentoMonologLogger;
 
 /**
  * Integration test for product view front action.
@@ -45,6 +46,11 @@ class ViewTest extends \Magento\TestFramework\TestCase\AbstractController
      */
     private $attributeSetRepository;
 
+    /**
+     * @var ProductAttributeRepositoryInterface $attributeSetRepository
+     */
+    private $attributeRepository;
+
     /**
      * @var Type $productEntityType
      */
@@ -59,6 +65,7 @@ protected function setUp()
 
         $this->productRepository = $this->_objectManager->create(ProductRepositoryInterface::class);
         $this->attributeSetRepository = $this->_objectManager->create(AttributeSetRepositoryInterface::class);
+        $this->attributeRepository = $this->_objectManager->create(ProductAttributeRepositoryInterface::class);
         $this->productEntityType = $this->_objectManager->create(Type::class)
             ->loadByCode(Product::ENTITY);
     }
@@ -94,32 +101,42 @@ public function testViewActionWithCanonicalTag(): void
      */
     public function testViewActionCustomAttributeSetWithoutCountryOfManufacture(): void
     {
+        /** @var MockObject|LoggerInterface $logger */
+        $logger = $this->setupLoggerMock();
+
         $product = $this->getProductBySku('simple_with_com');
         $attributeSetCustom = $this->getProductAttributeSetByName('custom_attribute_set_wout_com');
-
         $product->setAttributeSetId($attributeSetCustom->getAttributeSetId());
         $this->productRepository->save($product);
 
+        /** @var ProductAttributeInterface $attributeCountryOfManufacture */
+        $attributeCountryOfManufacture = $this->attributeRepository->get('country_of_manufacture');
+        $logger->expects($this->never())
+            ->method('warning')
+            ->with(
+                "Attempt to load value of nonexistent EAV attribute",
+                [
+                    'attribute_id' =>  $attributeCountryOfManufacture->getAttributeId(),
+                    'entity_type' => ProductInterface::class,
+                ]
+            );
+
         $this->dispatch(sprintf('catalog/product/view/id/%s/', $product->getId()));
-        $message = 'Attempt to load value of nonexistent EAV attribute';
-        $this->assertFalse(
-            $this->checkSystemLogForMessage($message),
-            sprintf("Warning message found in %s: %s", $this->systemLogFileName, $message)
-        );
     }
 
     /**
-     * Check system log file for error message.
+     * Setup logger mock to check there are no warning messages logged.
      *
-     * @param string $message
-     * @return bool
+     * @return MockObject
      */
-    private function checkSystemLogForMessage(string $message): bool
+    private function setupLoggerMock() : MockObject
     {
-        $content = $this->getSystemLogContent();
-        $pos = strpos($content, $message);
+        $logger = $this->getMockBuilder(LoggerInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->_objectManager->addSharedInstance($logger, MagentoMonologLogger::class);
 
-        return $pos !== false;
+        return $logger;
     }
 
     /**
@@ -165,86 +182,4 @@ private function getProductAttributeSetByName(string $attributeSetName): ?Set
 
         return null;
     }
-
-    /**
-     * Get system log content.
-     *
-     * @return string
-     */
-    private function getSystemLogContent(): string
-    {
-        $logDir = $this->getLogDirectoryWrite();
-        $logFile = $logDir->openFile($this->systemLogFileName, 'rb');
-        $content = $this->tail($logFile, 10);
-
-        return $content;
-    }
-
-    /**
-     * Get file tail.
-     *
-     * @param FileWriteInterface $file
-     * @param int $lines
-     * @param int $buffer
-     * @return false|string
-     */
-    private function tail(FileWriteInterface $file, int $lines = 10, int $buffer = 4096)
-    {
-        // Jump to last character
-        $file->seek(-1, SEEK_END);
-
-        // Read it and adjust line number if necessary
-        // (Otherwise the result would be wrong if file doesn't end with a blank line)
-        if ($file->read(1) != "\n") {
-            $lines--;
-        }
-
-        // Start reading
-        $output = '';
-        $chunk = '';
-
-        // While we would like more
-        while ($file->tell() > 0 && $lines >= 0) {
-            // Figure out how far back we should jump
-            $seek = min($file->tell(), $buffer);
-
-            // Do the jump (backwards, relative to where we are)
-            $file->seek(-$seek, SEEK_CUR);
-
-            // Read a chunk and prepend it to our output
-            $output = ($chunk = $file->read($seek)) . $output;
-
-            // Jump back to where we started reading
-            $file->seek(-mb_strlen($chunk, '8bit'), SEEK_CUR);
-
-            // Decrease our line counter
-            $lines -= substr_count($chunk, "\n");
-        }
-
-        // While we have too many lines
-        // (Because of buffer size we might have read too many)
-        while ($lines++ < 0) {
-            // Find first newline and remove all text before that
-            $output = substr($output, strpos($output, "\n") + 1);
-        }
-
-        // Close file and return
-        $file->close();
-
-        return $output;
-    }
-
-    /**
-     * Get current LOG directory write.
-     *
-     * @return WriteInterface
-     */
-    private function getLogDirectoryWrite()
-    {
-        /** @var Filesystem $filesystem */
-        $filesystem = $this->_objectManager->create(Filesystem::class);
-        $logDirectory = $filesystem->getDirectoryWrite(DirectoryList::LOG);
-
-        return $logDirectory;
-    }
 }

dev/tests/integration/testsuite/Magento/Catalog/_files/attribute_set_based_on_default_without_country_of_manufacture.php

@@ -7,7 +7,6 @@
 
 use Magento\Catalog\Api\Data\ProductAttributeInterface;
 use Magento\Catalog\Api\ProductAttributeRepositoryInterface;
-use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Attribute\Group;
 use Magento\Eav\Model\Entity\Attribute\Set;
 use Magento\Eav\Model\Entity\Type;

dev/tests/integration/testsuite/Magento/Catalog/_files/product_simple_with_country_of_manufacture.php

@@ -8,7 +8,6 @@
 use Magento\Catalog\Api\Data\ProductInterfaceFactory;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\TestFramework\Helper\Bootstrap;
-use Magento\Catalog\Model\Product;
 
 Bootstrap::getInstance()->reinitialize();