Add null as possible return type for getItemById method's PHPDocs

MTheProgrammer · MTheProgrammer · commit db881b3a0668 · 2024-02-13T10:23:15.000+08:00
diff --git a/app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/AbstractCollectionStub.php b/app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/AbstractCollectionStub.php
@@ -16,7 +16,7 @@ class AbstractCollectionStub extends AbstractCollection
      * Retrieve item by id
      *
      * @param   mixed $id
-     * @return  DataObject
+     * @return  DataObject|null
      */
     public function getItemById($id)
     {
diff --git a/app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/VersionControl/AbstractCollectionStub.php b/app/code/Magento/Eav/Test/Unit/Model/Entity/Collection/VersionControl/AbstractCollectionStub.php
@@ -19,7 +19,7 @@ class AbstractCollectionStub extends AbstractCollection
      * Retrieve item by id
      *
      * @param   mixed $id
-     * @return  DataObject
+     * @return  DataObject|null
      */
     public function getItemById($id)
     {
diff --git a/lib/internal/Magento/Framework/Data/Collection.php b/lib/internal/Magento/Framework/Data/Collection.php
@@ -825,7 +825,7 @@ protected function _toOptionHash($valueField = 'id', $labelField = 'name')
      * Retrieve item by id
      *
      * @param string|int $idValue
-     * @return DataObject
+     * @return DataObject|null
      */
     public function getItemById($idValue)
     {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class AbstractCollectionStub extends AbstractCollection`
`16`	`16`	`* Retrieve item by id`
`17`	`17`	`*`
`18`	`18`	`* @param mixed $id`
`19`		`- * @return DataObject`
	`19`	`+ * @return DataObject\|null`
`20`	`20`	`*/`
`21`	`21`	`public function getItemById($id)`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class AbstractCollectionStub extends AbstractCollection`
`19`	`19`	`* Retrieve item by id`
`20`	`20`	`*`
`21`	`21`	`* @param mixed $id`
`22`		`- * @return DataObject`
	`22`	`+ * @return DataObject\|null`
`23`	`23`	`*/`
`24`	`24`	`public function getItemById($id)`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -825,7 +825,7 @@ protected function _toOptionHash($valueField = 'id', $labelField = 'name')`
`825`	`825`	`* Retrieve item by id`
`826`	`826`	`*`
`827`	`827`	`* @param string\|int $idValue`
`828`		`- * @return DataObject`
	`828`	`+ * @return DataObject\|null`
`829`	`829`	`*/`
`830`	`830`	`public function getItemById($idValue)`
`831`	`831`	`{`