MAGETWO-39769: [GITHUB] lastInsertId returns 0 when PK is not AI #1445

Joan He · Joan He · commit db7177891076 · 2015-10-06T08:50:40.000-05:00
diff --git a/lib/internal/Magento/Framework/Model/Test/Unit/Resource/Db/AbstractDbTest.php b/lib/internal/Magento/Framework/Model/Test/Unit/Resource/Db/AbstractDbTest.php
@@ -491,7 +491,8 @@ public function testPrepareDataForUpdate()
     /**
      * Test that we only set/override id on object if PK autoincrement is enabled
      * @param bool $pkIncrement
-     * @dataProvider testSaveNewObjectDataProvider
+     * @dataProvider saveNewObjectDataProvider
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function testSaveNewObject($pkIncrement)
     {
@@ -549,7 +550,7 @@ public function testSaveNewObject($pkIncrement)
         $reflectionMethod->invokeArgs($model, [$inputObject]);
     }
 
-    public function testSaveNewObjectDataProvider()
+    public function saveNewObjectDataProvider()
     {
         return [[true], [false]];
     }

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,8 @@ public function testPrepareDataForUpdate()`
`491`	`491`	`/**`
`492`	`492`	`* Test that we only set/override id on object if PK autoincrement is enabled`
`493`	`493`	`* @param bool $pkIncrement`
`494`		`- * @dataProvider testSaveNewObjectDataProvider`
	`494`	`+ * @dataProvider saveNewObjectDataProvider`
	`495`	`+ * @SuppressWarnings(PHPMD.NPathComplexity)`
`495`	`496`	`*/`
`496`	`497`	`public function testSaveNewObject($pkIncrement)`
`497`	`498`	`{`
`@@ -549,7 +550,7 @@ public function testSaveNewObject($pkIncrement)`
`549`	`550`	`$reflectionMethod->invokeArgs($model, [$inputObject]);`
`550`	`551`	`}`
`551`	`552`
`552`		`- public function testSaveNewObjectDataProvider()`
	`553`	`+ public function saveNewObjectDataProvider()`
`553`	`554`	`{`
`554`	`555`	`return [[true], [false]];`
`555`	`556`	`}`