#24103: Refactoring.

Author: engcom-Foxtrot

app/code/Magento/AdminNotification/Block/Grid/Renderer/Actions.php

@@ -47,14 +47,14 @@ public function __construct(Context $context, Data $urlHelper, array $data = [])
      */
     public function render(DataObject $row)
     {
-        $readDetailsHtml = $row->getData('url') ? '<a class="action-details" target="_blank" href="' .
-            $this->escapeUrl($row->getData('url'))
+        $readDetailsHtml = $row->getUrl() ? '<a class="action-details" target="_blank" href="' .
+            $this->escapeUrl($row->getUrl())
             . '">' .
             __('Read Details') . '</a>' : '';
 
-        $markAsReadHtml = !$row->getData('is_read') ? '<a class="action-mark" href="' . $this->getUrl(
+        $markAsReadHtml = !$row->getIsRead() ? '<a class="action-mark" href="' . $this->getUrl(
             '*/*/markAsRead/',
-            ['_current' => true, 'id' => $row->getData('notification_id')]
+            ['_current' => true, 'id' => $row->getNotificationId()]
         ) . '">' . __(
             'Mark as Read'
         ) . '</a>' : '';
@@ -68,7 +68,7 @@ public function render(DataObject $row)
                 '*/*/remove/',
                 [
                     '_current' => true,
-                    'id' => $row->getData('notification_id'),
+                    'id' => $row->getNotificationId(),
                     ActionInterface::PARAM_NAME_URL_ENCODED => $encodedUrl
                 ]
             ),

app/code/Magento/AdminNotification/Block/Grid/Renderer/Notice.php

@@ -28,8 +28,8 @@ class Notice extends AbstractRenderer
     public function render(DataObject $row)
     {
         return '<span class="grid-row-title">' .
-            $this->escapeHtml($row->getData('title')) .
+            $this->escapeHtml($row->getTitle()) .
             '</span>' .
-            ($row->getData('description') ? '<br />' . $this->escapeHtml($row->getData('description')) : '');
+            ($row->getDescription() ? '<br />' . $this->escapeHtml($row->getDescription()) : '');
     }
 }

app/code/Magento/AdminNotification/Block/Grid/Renderer/Severity.php

@@ -50,7 +50,7 @@ public function render(DataObject $row)
         $value = '';
 
         $column = $this->getColumn();
-        $index  = $column->getData('index');
+        $index  = $column->getIndex();
         switch ($row->getData($index)) {
             case MessageInterface::SEVERITY_CRITICAL:
                 $class = 'critical';

app/code/Magento/AdminNotification/Test/Unit/Block/Grid/Renderer/SeverityTest.php

@@ -44,8 +44,11 @@ protected function setUp() : void
     public function testShouldRenderSeverity() : void
     {
         /** @var Column | \PHPUnit_Framework_MockObject_MockObject $columnMock */
-        $columnMock = $this->getMockBuilder(Column::class)->disableOriginalConstructor()->getMock();
-        $columnMock->expects($this->exactly(5))->method('getData')->with($this->equalTo('index'))->willReturn('index');
+        $columnMock = $this->getMockBuilder(Column::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getIndex'])
+            ->getMock();
+        $columnMock->expects($this->exactly(5))->method('getIndex')->willReturn('index');
         $this->sut->setColumn($columnMock);
         $dataObject = new DataObject();