Skip to content

Commit da303b8

Browse files
committed
MAGETWO-67283: quote_address.free_shipping is different depending on whether Magento was upgraded vs installed
1 parent 3c6f29f commit da303b8

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

app/code/Magento/OfflineShipping/Setup/UpgradeSchema.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
4040
}
4141

4242
/**
43-
* Modify free_shipping columns added incorrectly in InstallSchema.
43+
* Modify 'free_shipping' and 'simple_free_shipping' columns added incorrectly in InstallSchema.
4444
*
4545
* @param SchemaSetupInterface $setup
4646
* @return void
@@ -57,7 +57,6 @@ private function updateFreeShippingColumns(SchemaSetupInterface $setup)
5757
'default' => '0',
5858
'comment' => 'Simple Free Shipping',
5959
]
60-
6160
);
6261
$setup->getConnection(self::$salesConnectionName)->modifyColumn(
6362
$setup->getTable('sales_order_item', self::$salesConnectionName),
@@ -69,7 +68,6 @@ private function updateFreeShippingColumns(SchemaSetupInterface $setup)
6968
'default' => '0',
7069
'comment' => 'Free Shipping',
7170
]
72-
7371
);
7472
$setup->getConnection(self::$quoteConnectionName)->modifyColumn(
7573
$setup->getTable('quote_address', self::$quoteConnectionName),
@@ -81,7 +79,6 @@ private function updateFreeShippingColumns(SchemaSetupInterface $setup)
8179
'default' => '0',
8280
'comment' => 'Free Shipping',
8381
]
84-
8582
);
8683
$setup->getConnection(self::$quoteConnectionName)->modifyColumn(
8784
$setup->getTable('quote_item', self::$quoteConnectionName),

app/code/Magento/OfflineShipping/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
"magento/module-backend": "100.2.*",
99
"magento/module-shipping": "100.2.*",
1010
"magento/module-catalog": "101.1.*",
11+
"magento/module-sales": "100.2.*",
1112
"magento/module-sales-rule": "100.2.*",
1213
"magento/module-directory": "100.2.*",
1314
"magento/module-quote": "100.2.*",
1415
"magento/framework": "100.2.*"
1516
},
1617
"suggest": {
1718
"magento/module-checkout": "100.2.*",
18-
"magento/module-sales": "100.2.*",
1919
"magento/module-offline-shipping-sample-data": "Sample Data version:100.2.*"
2020
},
2121
"type": "magento2-module",

0 commit comments

Comments
 (0)