ACP2E-277: treat missing rules from authorization_rule table as deny permission rules; fix static errors / warnings

alzota · alzota · commit d9ca55e28aa2 · 2022-02-25T19:36:23.000+02:00
diff --git a/app/code/Magento/Authorization/Model/Acl/Loader/Rule.php b/app/code/Magento/Authorization/Model/Acl/Loader/Rule.php
@@ -85,6 +85,8 @@ public function populateAcl(\Magento\Framework\Acl $acl)
     }
 
     /**
+     * Apply ACL with rules
+     *
      * @param \Magento\Framework\Acl $acl
      * @return array[]
      */
@@ -114,7 +116,6 @@ private function applyPermissionsAccordingToRules(\Magento\Framework\Acl $acl):
     }
 
     /**
-     *
      * For all rules that were not regenerated in authorization_rule table,
      * when adding a new module and without re-saving all roles,
      * consider not present rules with deny permissions

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,8 @@ public function populateAcl(\Magento\Framework\Acl $acl)`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`/**`
	`88`	`+ * Apply ACL with rules`
	`89`	`+ *`
`88`	`90`	`* @param \Magento\Framework\Acl $acl`
`89`	`91`	`* @return array[]`
`90`	`92`	`*/`
`@@ -114,7 +116,6 @@ private function applyPermissionsAccordingToRules(\Magento\Framework\Acl $acl):`
`114`	`116`	`}`
`115`	`117`
`116`	`118`	`/**`
`117`		`- *`
`118`	`119`	`* For all rules that were not regenerated in authorization_rule table,`
`119`	`120`	`* when adding a new module and without re-saving all roles,`
`120`	`121`	`* consider not present rules with deny permissions`