Skip to content

Commit d9c224b

Browse files
author
Dmytro Aponasenko
committed
MTA-2350: Add wait to form element before filling a value
1 parent 70daff1 commit d9c224b

File tree

8 files changed

+8
-342
lines changed

8 files changed

+8
-342
lines changed

dev/tests/functional/tests/app/Magento/Backend/Test/Block/Widget/FormTabs.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ protected function fillTabs(array $tabs, SimpleElement $element = null)
8888
foreach ($tabs as $tabName => $tabFields) {
8989
$tab = $this->getTab($tabName);
9090
$this->openTab($tabName);
91-
$tab->fillFormTab(array_merge($tabFields, $this->unassignedFields), $context);
91+
$tab->fillFormTab($tabFields, $context);
9292
}
9393
if (!empty($this->unassignedFields)) {
9494
$this->fillMissedFields($tabs);

dev/tests/functional/tests/app/Magento/Customer/Test/Handler/Curl/CreateCustomer.php

Lines changed: 0 additions & 42 deletions
This file was deleted.

dev/tests/functional/tests/app/Magento/Customer/Test/Handler/Curl/CreateCustomerBackend.php

Lines changed: 0 additions & 75 deletions
This file was deleted.

dev/tests/functional/tests/app/Magento/Customer/Test/Handler/Curl/SaveCustomerWithAddress.php

Lines changed: 0 additions & 147 deletions
This file was deleted.

dev/tests/functional/tests/app/Magento/Customer/Test/Handler/Ui/CreateAddress.php

Lines changed: 0 additions & 38 deletions
This file was deleted.

dev/tests/functional/tests/app/Magento/Customer/Test/Handler/Webapi/CreateCustomer.php

Lines changed: 0 additions & 32 deletions
This file was deleted.

dev/tests/functional/tests/app/Magento/Directory/Test/TestCase/CreateCurrencyRateTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
* 5. Perform assertions.
2626
*
2727
* @group Localization_(PS)
28-
* @ZephyrId MAGETWO-12427, MAGETWO-36824
28+
* @ZephyrId MAGETWO-36824
2929
*/
3030
class CreateCurrencyRateTest extends Injectable
3131
{

dev/tests/functional/tests/app/Magento/UrlRewrite/Test/Block/Adminhtml/Catalog/Edit/UrlRewriteForm.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,21 @@
1717
class UrlRewriteForm extends Form
1818
{
1919
/**
20-
* Get target path value for url rewrite fixture.
20+
* Prepare data for url rewrite fixture.
2121
*
2222
* @param FixtureInterface $fixture
23-
* @return string|void
23+
* @return array
2424
*/
25-
protected function getTargetPath(FixtureInterface $fixture)
25+
protected function prepareData(FixtureInterface $fixture)
2626
{
2727
$data = $fixture->getData();
2828
if (empty($data['entity_type']) && empty($this->getData()['target_path']) && !isset($data['target_path'])) {
2929
$entity = $fixture->getDataFieldConfig('target_path')['source']->getEntity();
30-
return $entity->hasData('identifier')
30+
$data['target_path'] = $entity->hasData('identifier')
3131
? $entity->getIdentifier()
3232
: $entity->getUrlKey() . '.html';
3333
}
34+
return $data;
3435
}
3536

3637
/**
@@ -65,8 +66,7 @@ public function fill(
6566
array $replace = []
6667
) {
6768
$context = ($element === null) ? $this->_rootElement : $element;
68-
$data = $fixture->getData();
69-
$data['target_path'] = $this->getTargetPath($fixture);
69+
$data = $this->prepareData($fixture);
7070

7171
foreach ($replace as $key => $value) {
7272
if (isset($data[$key])) {

0 commit comments

Comments
 (0)