Skip to content

Commit d990c95

Browse files
#10045 Sitemap add item refactoring - fix coding standards
1 parent becd97c commit d990c95

10 files changed

+19
-18
lines changed

app/code/Magento/Sitemap/Model/CategorySitemapItemResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function __construct(
6464
public function getItems($storeId)
6565
{
6666
$collection = $this->categoryFactory->create()->getCollection($storeId);
67-
$items = array_map(function($item) use ($storeId) {
67+
$items = array_map(function ($item) use ($storeId) {
6868
return $this->itemFactory->create([
6969
'url' => $item->getUrl(),
7070
'updatedAt' => $item->getUpdatedAt(),
@@ -106,4 +106,4 @@ private function getCategoryChangeFrequency($storeId)
106106
$storeId
107107
);
108108
}
109-
}
109+
}

app/code/Magento/Sitemap/Model/CmsPageSitemapItemResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function __construct(
6565
public function getItems($storeId)
6666
{
6767
$collection = $this->cmsPageFactory->create()->getCollection($storeId);
68-
$items = array_map(function($item) use ($storeId) {
68+
$items = array_map(function ($item) use ($storeId) {
6969
return $this->itemFactory->create([
7070
'url' => $item->getUrl(),
7171
'updatedAt' => $item->getUpdatedAt(),
@@ -107,4 +107,4 @@ private function getPageChangeFrequency($storeId)
107107
$storeId
108108
);
109109
}
110-
}
110+
}

app/code/Magento/Sitemap/Model/CompositeSitemapItemResolver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ public function getItems($storeId)
4141

4242
return $items;
4343
}
44-
}
44+
}

app/code/Magento/Sitemap/Model/ProductSitemapItemResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function __construct(
6363
public function getItems($storeId)
6464
{
6565
$collection = $this->productFactory->create()->getCollection($storeId);
66-
$items = array_map(function($item) use ($storeId) {
66+
$items = array_map(function ($item) use ($storeId) {
6767
return $this->itemFactory->create([
6868
'url' => $item->getUrl(),
6969
'updatedAt' => $item->getUpdatedAt(),
@@ -105,4 +105,4 @@ private function getProductChangeFrequency($storeId)
105105
$storeId
106106
);
107107
}
108-
}
108+
}

app/code/Magento/Sitemap/Model/SitemapItem.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,4 @@ public function getUpdatedAt()
9090
{
9191
return $this->updatedAt;
9292
}
93-
}
93+
}

app/code/Magento/Sitemap/Model/SitemapItemInterface.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
*
1212
* @api
1313
*/
14-
interface SitemapItemInterface {
14+
interface SitemapItemInterface
15+
{
1516

1617
/**
1718
* Get url
@@ -47,4 +48,4 @@ public function getImages();
4748
* @return string|null
4849
*/
4950
public function getUpdatedAt();
50-
}
51+
}

app/code/Magento/Sitemap/Model/SitemapItemResolverInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ interface SitemapItemResolverInterface
1919
* @return SitemapItemInterface[]
2020
*/
2121
public function getItems($storeId);
22-
}
22+
}

app/code/Magento/Sitemap/Test/Unit/Model/CategorySitemapItemResolverTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,4 +149,4 @@ private function getCategoryCollectionMock($returnValue)
149149

150150
return $sitemapCmsPageMock;
151151
}
152-
}
152+
}

app/code/Magento/Sitemap/Test/Unit/Model/CmsPageSitemapItemResolverTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testGetItems(array $pages = [])
5151
$resolver = new CmsPageSitemapItemResolver($storeConfigMock, $cmsPageFactoryMock, $itemFactoryMock);
5252
$items = $resolver->getItems(1);
5353
self::assertTrue(count($items) == count($pages));
54-
foreach($pages as $index => $page) {;
54+
foreach ($pages as $index => $page) {
5555
self::assertSame($page->getUpdatedAt(), $items[$index]->getUpdatedAt());
5656
self::assertSame('daily', $items[$index]->getChangeFrequency());
5757
self::assertSame('1.0', $items[$index]->getPriority());

app/code/Magento/Sitemap/Test/Unit/Model/CompositeSitemapItemResolverTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function testGetItems($itemResolverData, $expectedItems)
2626
{
2727
$mockResolvers = [];
2828

29-
foreach($itemResolverData as $data) {
29+
foreach ($itemResolverData as $data) {
3030
$mockResolver = $this->getMockForAbstractClass(SitemapItemResolverInterface::class);
3131
$mockResolver->expects(self::once())
3232
->method('getItems')
@@ -48,12 +48,12 @@ public function sitemapItemsProvider()
4848
{
4949
$testCases = [];
5050

51-
for($i = 1; $i < 5; $i++) {
51+
for ($i = 1; $i < 5; $i++) {
5252
$itemProviders = [];
5353
$expectedItems = [];
54-
for($i = 1; $i < $maxProviders = random_int(1, 5); $i++) {
54+
for ($i = 1; $i < $maxProviders = random_int(1, 5); $i++) {
5555
$items = [];
56-
for($i = 1; $i < $maxItems = random_int(2, 5); $i++) {
56+
for ($i = 1; $i < $maxItems = random_int(2, 5); $i++) {
5757
$sitemapItem = $this->getMockForAbstractClass(SitemapItemInterface::class);
5858
$items[] = $sitemapItem;
5959
$expectedItems[] = $sitemapItem;
@@ -66,4 +66,4 @@ public function sitemapItemsProvider()
6666

6767
return $testCases;
6868
}
69-
}
69+
}

0 commit comments

Comments
 (0)