Skip to content

Commit d94e0a1

Browse files
committed
ACP2E-3709: [Cloud] Changing table column type from Int to Decimal using db_schema.xml file In Magento 2 Results In Errors
1 parent 489b18f commit d94e0a1

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/internal/Magento/Framework/Config/Reader/Filesystem.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ protected function _readFiles($fileList)
217217
*
218218
* @param string $mergerClass
219219
* @param string $initialContents
220-
* @param string $typeAttributeName
221220
* @return \Magento\Framework\Config\Dom
222221
* @throws \UnexpectedValueException
223222
*/
@@ -244,7 +243,8 @@ protected function _createConfigMerger($mergerClass, $initialContents)
244243
* @param string $filePath
245244
* @return bool
246245
*/
247-
private function isDbSchemaFile(string $filePath): bool {
246+
private function isDbSchemaFile(string $filePath): bool
247+
{
248248
// Check only if "db_schema.xml" is at the very end of the path
249249
$pattern = '/db_schema\.xml$/';
250250
return preg_match($pattern, $filePath) === 1;

lib/internal/Magento/Framework/Config/Test/Unit/Reader/FilesystemTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ protected function setUp(): void
7878
'test.xml',
7979
['/test/node' => 'id'],
8080
Dom::class,
81-
'global'
81+
'global',
82+
'xsi:type'
8283
);
8384
}
8485

0 commit comments

Comments
 (0)