Skip to content

Commit d93fe31

Browse files
committed
fix #25761 - resolved feedbacks
1 parent 8f5b2c7 commit d93fe31

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

app/code/Magento/Sitemap/Model/ItemProvider/StoreUrlConfigReader.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function __construct(ScopeConfigInterface $scopeConfig)
3636
}
3737

3838
/**
39-
* {@inheritdoc}
39+
* @inheritdoc
4040
*/
4141
public function getPriority($storeId)
4242
{
@@ -48,7 +48,7 @@ public function getPriority($storeId)
4848
}
4949

5050
/**
51-
* {@inheritdoc}
51+
* @inheritdoc
5252
*/
5353
public function getChangeFrequency($storeId)
5454
{

app/code/Magento/Sitemap/Test/Unit/Model/ItemProvider/StoreUrlTest.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@
1111
use Magento\Sitemap\Model\ItemProvider\StoreUrl as StoreUrlItemResolver;
1212
use Magento\Sitemap\Model\SitemapItem;
1313
use Magento\Sitemap\Model\SitemapItemInterfaceFactory;
14+
use PHPUnit\Framework\MockObject\MockObject;
15+
use PHPUnit\Framework\TestCase;
1416

15-
class StoreUrlTest extends \PHPUnit\Framework\TestCase
17+
class StoreUrlTest extends TestCase
1618
{
1719
/**
1820
* test for getItems method
@@ -24,15 +26,15 @@ public function testGetItems()
2426
$resolver = new StoreUrlItemResolver($configReaderMock, $itemFactoryMock);
2527
$items = $resolver->getItems(1);
2628

27-
$this->assertTrue(count($items) == 1);
29+
$this->assertCount(1, $items);
2830
foreach ($items as $item) {
2931
$this->assertSame('daily', $item->getChangeFrequency());
3032
$this->assertSame('1.0', $item->getPriority());
3133
}
3234
}
3335

3436
/**
35-
* @return \PHPUnit_Framework_MockObject_MockObject
37+
* @return SitemapItemInterfaceFactory|MockObject
3638
*/
3739
private function getItemFactoryMock()
3840
{
@@ -53,7 +55,7 @@ private function getItemFactoryMock()
5355
}
5456

5557
/**
56-
* @return \PHPUnit_Framework_MockObject_MockObject
58+
* @return ConfigReaderInterface|MockObject
5759
*/
5860
private function getConfigReaderMock()
5961
{

0 commit comments

Comments
 (0)