Skip to content

Commit d87df89

Browse files
committed
ENGCOM-144: Port accepted Pull Requests from 2.2 to 2.3
- Fixes based on static tests
1 parent 73d2f7a commit d87df89

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

app/code/Magento/Catalog/Test/Unit/Block/Product/View/GalleryTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
*/
66
namespace Magento\Catalog\Test\Unit\Block\Product\View;
77

8+
/**
9+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
10+
*/
811
class GalleryTest extends \PHPUnit\Framework\TestCase
912
{
1013
/**

app/code/Magento/CatalogImportExport/Model/Import/Product.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
use Magento\ImportExport\Model\Import\ErrorProcessing\ProcessingError;
2121
use Magento\ImportExport\Model\Import\ErrorProcessing\ProcessingErrorAggregatorInterface;
2222
use Magento\Store\Model\Store;
23+
use Magento\Framework\App\ObjectManager;
2324

2425
/**
2526
* Import entity product model
@@ -830,12 +831,9 @@ public function __construct(
830831
$this->scopeConfig = $scopeConfig;
831832
$this->productUrl = $productUrl;
832833
$this->dateAttrCodes = array_merge($this->dateAttrCodes, $dateAttrCodes);
833-
$this->catalogConfig = $catalogConfig ?: \Magento\Framework\App\ObjectManager::getInstance()
834-
->get(CatalogConfig::class);
835-
$this->imageTypeProcessor = $imageTypeProcessor ?: \Magento\Framework\App\ObjectManager::getInstance()
836-
->get(ImageTypeProcessor::class);
837-
$this->mediaProcessor = $mediaProcessor ?: \Magento\Framework\App\ObjectManager::getInstance()
838-
->get(MediaGalleryProcessor::class);
834+
$this->catalogConfig = $catalogConfig ?: ObjectManager::getInstance()->get(CatalogConfig::class);
835+
$this->imageTypeProcessor = $imageTypeProcessor ?: ObjectManager::getInstance()->get(ImageTypeProcessor::class);
836+
$this->mediaProcessor = $mediaProcessor ?: ObjectManager::getInstance()->get(MediaGalleryProcessor::class);
839837

840838
parent::__construct(
841839
$jsonHelper,

0 commit comments

Comments
 (0)