MAGETWO-94819: Swatch validation breaks the whole attribute form

Author: fascinosum

app/code/Magento/Swatches/Test/Mftf/Test/AdminCreateVisualSwatchWithNonValidOptionsTest.xml

@@ -17,7 +17,7 @@
             <group value="Swatches"/>
         </annotations>
         <before>
-            <actionGroup ref="LoginActionGroup" stepKey="login"/>
+            <actionGroup ref="LoginAsAdmin" stepKey="login"/>
         </before>
         <after>
             <!-- Remove attribute -->

dev/tests/acceptance/.gitignore

@@ -7,4 +7,5 @@ tests/functional.suite.yml
 tests/functional/Magento/FunctionalTest/_generated
 vendor/*
 mftf.log
+/.credentials.example
 /utils/

dev/tests/functional/tests/app/Magento/Catalog/Test/Handler/CatalogProductAttribute/Curl.php

@@ -134,11 +134,72 @@ public function persist(FixtureInterface $fixture = null)
     }
 
     /**
+     * Additional data handling.
+     *
      * @param array $data
      * @return array
      */
     protected function changeStructureOfTheData(array $data)
     {
+        $serializedOptions = $this->getSerializeOptions($data, ['option']);
+        if ($serializedOptions) {
+            $data['serialized_options'] = $serializedOptions;
+            unset($data['option']);
+        }
+
         return $data;
     }
+
+    /**
+     * Provides serialized product attribute options.
+     *
+     * @param array $data
+     * @param array $optionKeys
+     * @return array
+     */
+    protected function getSerializeOptions(array $data, array $optionKeys): string
+    {
+        $options = [];
+        foreach ($optionKeys as $optionKey) {
+            if (!empty($data[$optionKey])) {
+                $options = array_merge(
+                    $options,
+                    $this->getEncodedOptions([$optionKey => $data[$optionKey]])
+                );
+            }
+        }
+
+        return json_encode($options);
+    }
+
+    /**
+     * Provides encoded attribute values.
+     *
+     * @param array $data
+     * @return array
+     */
+    private function getEncodedOptions(array $data): array
+    {
+        $optionsData = [];
+        $iterator = new \RecursiveIteratorIterator(new \RecursiveArrayIterator($data));
+        foreach ($iterator as $value) {
+            $depth = $iterator->getDepth();
+            $option = '';
+
+            $level = 0;
+            $option .= $iterator->getSubIterator($level)->key();
+            $level++;
+
+            while ($level <= $depth) {
+                $option .= '[' . $iterator->getSubIterator($level)->key() . ']';
+                $level++;
+            }
+
+            $option .= '=' . $value;
+
+            $optionsData[] = $option;
+        }
+
+        return $optionsData;
+    }
 }

dev/tests/functional/tests/app/Magento/Swatches/Test/Handler/SwatchProductAttribute/Curl.php

@@ -38,12 +38,14 @@ public function __construct(DataInterface $configuration, EventManagerInterface
      */
     protected function changeStructureOfTheData(array $data)
     {
-        $data = parent::changeStructureOfTheData($data);
         $data['optiontext'] = $data['option'];
         $data['swatchtext'] = [
             'value' => $data['option']['value']
         ];
+        $data['serialized_options'] = $this->getSerializeOptions($data, ['optiontext', 'swatchtext']);
         unset($data['option']);
+        $data = parent::changeStructureOfTheData($data);
+
         return $data;
     }
 }