MC-32427: Sign locks in order to prevent unlock from parallel request

vzabaznov · vzabaznov · commit d83a0aea2ca3 · 2020-04-15T14:30:05.000-05:00
diff --git a/lib/internal/Magento/Framework/Lock/Backend/Cache.php b/lib/internal/Magento/Framework/Lock/Backend/Cache.php
@@ -45,7 +45,12 @@ public function __construct(FrontendInterface $cache)
     public function lock(string $name, int $timeout = -1): bool
     {
         if (empty($this->lockSign)) {
-            $this->lockSign = \bin2hex(\random_bytes(8));
+            $this->lockSign = implode(
+                '-',
+                [
+                    \getmypid(), \crc32(\gethostname()), \bin2hex(\random_bytes(4))
+                ]
+            );
         }
 
         $data = $this->cache->load($this->getIdentifier($name));

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,12 @@ public function __construct(FrontendInterface $cache)`
`45`	`45`	`public function lock(string $name, int $timeout = -1): bool`
`46`	`46`	`{`
`47`	`47`	`if (empty($this->lockSign)) {`
`48`		`- $this->lockSign = \bin2hex(\random_bytes(8));`
	`48`	`+ $this->lockSign = implode(`
	`49`	`+ '-',`
	`50`	`+ [`
	`51`	`+ \getmypid(), \crc32(\gethostname()), \bin2hex(\random_bytes(4))`
	`52`	`+ ]`
	`53`	`+ );`
`49`	`54`	`}`
`50`	`55`
`51`	`56`	`$data = $this->cache->load($this->getIdentifier($name));`