MAGETWO-95595: Index names are ignored by declarative schema

- test disable index

Author: rganin

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule1/etc/db_schema.xml

@@ -65,5 +65,8 @@
             <column name="tinyint"/>
             <column name="bigint"/>
         </index>
+        <index referenceId="TEST_TABLE_INDEX_VARCHAR" indexType="btree">
+            <column name="varchar"/>
+        </index>
     </table>
 </schema>

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule1/revisions/index_to_disable/db_schema.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
+    <table name="test_table" resource="default">
+        <!--Columns-->
+        <column xsi:type="smallint" identity="true" name="smallint" padding="3" nullable="true"/>
+        <column xsi:type="tinyint" name="tinyint" padding="7" nullable="true" unsigned="false"/>
+        <column xsi:type="bigint" name="bigint" default="0" padding="13" nullable="true" unsigned="false"/>
+        <column xsi:type="varchar" name="varchar" length="254" nullable="true"/>
+        <!--Constraints-->
+        <constraint xsi:type="unique" referenceId="TEST_TABLE_UNIQUE">
+            <column name="smallint"/>
+            <column name="bigint"/>
+        </constraint>
+        <!--Indexes-->
+        <index referenceId="TEST_TABLE_INDEX" indexType="btree">
+            <column name="tinyint"/>
+            <column name="bigint"/>
+        </index>
+        <index referenceId="TEST_TABLE_INDEX_VARCHAR" indexType="btree">
+            <column name="varchar"/>
+        </index>
+    </table>
+</schema>

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule8/revisions/disable_index_by_external_module/db_schema.xml

@@ -8,6 +8,6 @@
 <schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
     <table name="test_table" resource="default">
-        <index referenceId="TEST_TABLE_TINYINT_BIGINT" disabled="1"/>
+        <index referenceId="TEST_TABLE_INDEX_VARCHAR" disabled="1"/>
     </table>
 </schema>

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule8/revisions/disable_index_by_external_module/db_schema_whitelist.json

@@ -0,0 +1,7 @@
+{
+  "test_table": {
+    "index": {
+      "TEST_TABLE_VARCHAR": true
+    }
+  }
+}

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule8/revisions/disable_index_by_external_module/module.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
+    <module name="Magento_TestSetupDeclarationModule8">
+        <sequence>
+            <module name="Magento_TestSetupDeclarationModule1" />
+        </sequence>
+    </module>
+</config>

dev/tests/setup-integration/testsuite/Magento/Setup/DeclarativeInstallerTest.php

@@ -343,17 +343,35 @@ public function testDisableIndexByExternalModule()
         $this->cliCommad->install(
             ['Magento_TestSetupDeclarationModule1', 'Magento_TestSetupDeclarationModule8']
         );
+        $this->moduleManager->updateRevision(
+            'Magento_TestSetupDeclarationModule1',
+            'index_to_disable',
+            'db_schema.xml',
+            'etc'
+        );
         $this->moduleManager->updateRevision(
             'Magento_TestSetupDeclarationModule8',
             'disable_index_by_external_module',
             'db_schema.xml',
             'etc'
         );
+        $this->moduleManager->updateRevision(
+            'Magento_TestSetupDeclarationModule8',
+            'disable_index_by_external_module',
+            'db_schema_whitelist.json',
+            'etc'
+        );
+        $this->moduleManager->updateRevision(
+            'Magento_TestSetupDeclarationModule8',
+            'disable_index_by_external_module',
+            'module.xml',
+            'etc'
+        );
         $this->cliCommad->upgrade();
         $tableStatements = $this->describeTable->describeShard('default');
         $tableSql = $tableStatements['test_table'];
         $this->assertNotRegExp(
-            '/KEY\s+`TEST_TABLE_TINYINT_BIGINT`\s+\(`tinyint`,`bigint`\)/',
+            '/KEY\s+`TEST_TABLE_VARCHAR`\s+\(`varchar`\)/',
             $tableSql,
             'Index is not being disabled by external module'
         );