Skip to content

Commit d71c970

Browse files
Manoranjan.PrakashManoranjan.Prakash
Manoranjan.Prakash
authored and
Manoranjan.Prakash
committed
fixed the static check errors
1 parent 91ad93b commit d71c970

File tree

7 files changed

+0
-29
lines changed

7 files changed

+0
-29
lines changed

‎app/code/Magento/Swatches/Test/Mftf/ActionGroup/AdminUpdateAttributeUsedForSortingInProductListingActionGroup.xml renamed to ‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminUpdateAttributeUsedForSortingInProductListingActionGroup.xml

File renamed without changes.

‎app/code/Magento/Catalog/Test/Mftf/Data/ProductAttributeData.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,6 @@
443443
<data key="attribute_code">attribute</data>
444444
<requiredEntity type="FrontendLabel">ProductAttributeFrontendLabelForExportImport</requiredEntity>
445445
</entity>
446-
447446
<!-- Product attributes for sorting in product listing as No -->
448447
<entity name="textAttributeWithNoProductSortListing" extends="newProductAttribute" type="ProductAttribute">
449448
<data key="used_for_sort_by">false</data>

‎app/code/Magento/Catalog/Test/Mftf/Section/AdminCreateProductAttributeSection/StorefrontPropertiesSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<element name="useForPromoRuleConditions" type="select" selector="#is_used_for_promo_rules"/>
1515
<element name="StorefrontPropertiesSectionToggle" type="button" selector="#front_fieldset-wrapper"/>
1616
<element name="visibleOnCatalogPagesOnStorefront" type="select" selector="#is_visible_on_front"/>
17-
1817
<element name="usedForSortingInProductListing" type="select" selector="#used_for_sort_by"/>
1918
</section>
2019
</sections>

‎app/code/Magento/Catalog/Test/Mftf/Section/AdminProductAttributeGridSection.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@
2525
<element name="isComparableColumn" type="text" selector="//div[@id='attributeGrid']//td[contains(@class,'a-center col-is_comparable')]"/>
2626
<element name="addSelected" type="button" selector="//*[contains(text(),'Add Selected')]" timeout="30"/>
2727
<element name="deleteSpecificColorAttribute" type="button" selector="//input[@value='{{var}}']/../..//button[@class='action- scalable delete delete-option']" parameterized="true"/>
28-
2928
<element name="attributeNameInGrid" type="text" selector="//td[contains(@class,'col-attribute_code') and contains(text(),'{{attribute_code}}')]/following-sibling::td[contains(@class,'col-frontend_label')]" parameterized="true"/>
30-
3129
</section>
3230
</sections>
3331

‎app/code/Magento/Catalog/Test/Mftf/Section/StorefrontCategoryMainSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
<element name="outOfStockProductCategoryPage" type="text" selector="//div[@class='stock unavailable']//span[text()='Out of stock']"/>
4747
<element name="ListedProductAttributes" type="block" selector="//div[@aria-label='{{vs_attribute}}']//div[@aria-label='{{attribute_name}}']" parameterized="true"/>
4848
<element name="quickOrderLink" type="text" selector="//div[@class='panel header']//a[text()='Quick Order']" />
49-
5049
<element name="sortByDropdownContent" type="select" selector="//select[@id='sorter']//option[contains(text(),'{{arg}}')]" parameterized="true"/>
5150
<element name="productInOrderDisplay" type="text" selector="//li[@class='item product product-item'][{{index}}]//a[@class='product-item-link' and contains(text(),'{{product_name}}')]" parameterized="true"/>
5251
</section>

‎app/code/Magento/Catalog/Test/Mftf/Section/StorefrontCategorySidebarSection/StorefrontCategorySidebarSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
<element name="seeLayeredNavigationCategoryVisualSwatch" type="text" selector="//div[@class='filter-options-title' and contains(text(),'attribute')]"/>
3232
<element name="seeTextSwatchOption" type="text" selector="//div[@class='swatch-option text ' and contains(text(),'textSwatchOption1')]"/>
3333
<element name="seeVisualSwatchOption" type="text" selector="//div[@class='swatch-option image ']/..//div[@data-option-label='visualSwatchOption2']"/>
34-
3534
<element name="expandLayeredNavigationAttribute" type="button" selector="//div[@class='filter-options-title' and text()='{{AttributeName}}']" parameterized="true"/>
3635
<element name="layeredNavigationAttributeOptions" type="button" selector="//div[@class='filter-options-title' and text()='{{AttributeName}}']/following-sibling::div//a[text()='{{arg}}']" parameterized="true"/>
3736
</section>

‎app/code/Magento/Catalog/Test/Mftf/Test/StorefrontPropertiesOfAProductAttributeTest.xml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
<createData entity="CatalogAttributeSet" stepKey="createAttributeSet"/>
3939
<!-- Step4: Create Text Attribute with used for Sorting in Product Listing as No -->
4040
<createData entity="textAttributeWithNoProductSortListing" stepKey="createTextProductAttribute"/>
41-
4241
<!-- Step5: Create Date Attribute with used for Sorting in Product Listing as No -->
4342
<createData entity="dateAttributeWithNoProductSortListing" stepKey="createDateProductAttribute"/>
4443
<!-- Step6: Create Yes / No Attribute with used for Sorting in Product Listing as No -->
@@ -75,7 +74,6 @@
7574
<argument name="usedForSortingInProductListing" value="No"/>
7675
</actionGroup>
7776
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveDropdownProductAttributeWith2Options"/>
78-
7977
<!-- Step9: Create Price Attribute with used for Sorting in Product Listing as No -->
8078
<createData entity="priceAttributeWithNoProductSortListing" stepKey="createPriceProductAttribute"/>
8179
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openPriceAttributeFromSearchResultInGrid">
@@ -86,7 +84,6 @@
8684
</actionGroup>
8785
<selectOption selector="{{AttributePropertiesSection.useInLayeredNavigation}}" userInput="Filterable (with results)" stepKey="setDropdownUseInLayeredNavigationAsNoForPriceAttribute"/>
8886
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveForPriceAttribute"/>
89-
9087
<!-- Step9.1: Grab all the product attribute names -->
9188
<actionGroup ref="SearchAttributeByCodeOnProductAttributeGridActionGroup" stepKey="navigateToProductAttributeGridToGrabTextAttributeName">
9289
<argument name="productAttributeCode" value="attr"/>
@@ -97,7 +94,6 @@
9794
<grabTextFrom selector="{{AdminProductAttributeGridSection.attributeNameInGrid('$$createMultiSelectProductAttributeWith2Options.attribute_code$$')}}" stepKey="grabMultiSelectAttributeName"/>
9895
<grabTextFrom selector="{{AdminProductAttributeGridSection.attributeNameInGrid('$$createDropdownProductAttributeWith2Options.attribute_code$$')}}" stepKey="grabDropdownAttributeName"/>
9996
<grabTextFrom selector="{{AdminProductAttributeGridSection.attributeNameInGrid('$$createPriceProductAttribute.attribute_code$$')}}" stepKey="grabPriceAttributeName"/>
100-
10197
<!-- Step10-13: Add all the created 6 attributes to the created attribute set -->
10298
<actionGroup ref="AdminOpenAttributeSetGridPageActionGroup" stepKey="openAttributeSetPage"/>
10399
<actionGroup ref="GoToAttributeSetByNameActionGroup" stepKey="OpenAttributeSet">
@@ -128,7 +124,6 @@
128124
<argument name="attribute" value="$$createPriceProductAttribute.attribute_code$$"/>
129125
</actionGroup>
130126
<actionGroup ref="SaveAttributeSetActionGroup" stepKey="saveAttributeSet"/>
131-
132127
<!-- Step 14-20: Create 2 simple products with above created attribute set-->
133128
<createData entity="_defaultCategory" stepKey="createCategory"/>
134129
<createData entity="_defaultProduct" stepKey="createSimpleProduct1">
@@ -139,10 +134,8 @@
139134
<requiredEntity createDataKey="createCategory"/>
140135
<field key="attribute_set_id">$$createAttributeSet.attribute_set_id$$</field>
141136
</createData>
142-
143137
<generateDate date="now" format="m/d/Y" stepKey="generateCurrentDate"/>
144138
<generateDate date="-1 day" format="m/d/Y" stepKey="generateYesterdayDate"/>
145-
146139
<amOnPage url="{{AdminProductIndexPage.url}}" stepKey="navigateToProductIndexPageToEditProduct1"/>
147140
<actionGroup ref="OpenEditProductOnBackendActionGroup" stepKey="openEditSimpleProduct1">
148141
<argument name="product" value="$$createSimpleProduct1$$"/>
@@ -154,7 +147,6 @@
154147
<fillField selector="{{AdminProductFormSection.customTextAttribute('$$createPriceProductAttribute.attribute_code$$')}}" userInput="123" stepKey="setValueForCustomPriceAttributeForSimpleProduct1"/>
155148
<conditionalClick selector="{{AdminProductFormSection.customSwitcherAttribute('$$createYesNoProductAttribute.attribute_code$$','1')}}" dependentSelector="{{AdminProductFormSection.customSwitcherAttribute('$$createYesNoProductAttribute.attribute_code$$','1')}}" visible="true" stepKey="selectNoForCustomYesNoAttributeForSimpleProduct1"/>
156149
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveSimpleProduct1"/>
157-
158150
<amOnPage url="{{AdminProductIndexPage.url}}" stepKey="navigateToProductIndexPageToEditProduct2"/>
159151
<actionGroup ref="OpenEditProductOnBackendActionGroup" stepKey="openEditSimpleProduct2">
160152
<argument name="product" value="$$createSimpleProduct2$$"/>
@@ -166,15 +158,13 @@
166158
<fillField selector="{{AdminProductFormSection.customTextAttribute('$$createPriceProductAttribute.attribute_code$$')}}" userInput="456" stepKey="setValueForCustomPriceAttributeForSimpleProduct2"/>
167159
<conditionalClick selector="{{AdminProductFormSection.customSwitcherAttribute('$$createYesNoProductAttribute.attribute_code$$','0')}}" dependentSelector="{{AdminProductFormSection.customSwitcherAttribute('$$createYesNoProductAttribute.attribute_code$$','0')}}" visible="true" stepKey="selectNoForCustomYesNoAttributeForSimpleProduct2"/>
168160
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveSimpleProduct2"/>
169-
170161
<!-- Clear index and flush cache -->
171162
<actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex1">
172163
<argument name="indices" value=""/>
173164
</actionGroup>
174165
<actionGroup ref="CliCacheFlushActionGroup" stepKey="cleanCacheAsCleanUp">
175166
<argument name="tags" value="config full_page"/>
176167
</actionGroup>
177-
178168
<!-- Step 21-23: Navigate to the category on storefront and assert the created Products-->
179169
<actionGroup ref="StorefrontNavigateToCategoryUrlActionGroup" stepKey="NavigateToCategoryPageOnStoreFront">
180170
<argument name="categoryUrl" value="$$createCategory.custom_attributes[url_key]$$"/>
@@ -187,29 +177,25 @@
187177
<argument name="productName" value="$$createSimpleProduct2.name$$"/>
188178
<argument name="index" value="2"/>
189179
</actionGroup>
190-
191180
<!-- Step 24: Verify the Sort by dropdown options -->
192181
<click selector="{{StorefrontCategoryMainSection.sortedBy}}" stepKey="clickOnSortByDropdown"/>
193182
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('Position')}}" stepKey="assertPositionOptionInDropdown"/>
194183
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('Product Name')}}" stepKey="assertProductNameOptionInDropdown"/>
195184
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('Price')}}" stepKey="assertPriceOptionInDropdown"/>
196-
197185
<!-- Step 25: Check the list of attributes in the Layered Navigation Section -->
198186
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabDropdownAttributeName}')}}" stepKey="assertDropdownAttributeInLayeredNavigation"/>
199187
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabMultiSelectAttributeName}')}}" stepKey="assertMultiSelectAttributeInLayeredNavigation"/>
200188
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabPriceAttributeName}')}}" stepKey="assertPriceAttributeInLayeredNavigation"/>
201189
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabTextAttributeName}')}}" stepKey="assertTextAttributeNotPresentInLayeredNavigation"/>
202190
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabDateAttributeName}')}}" stepKey="assertDateAttributeNotPresentInLayeredNavigation"/>
203191
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabYesNoAttributeName}')}}" stepKey="assertYesNoAttributeNotPresentInLayeredNavigation"/>
204-
205192
<!-- Step 26-27: Check the list of options in the Attributes dropdown in the Layered Navigation Section -->
206193
<conditionalClick selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabMultiSelectAttributeName}')}}" dependentSelector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabMultiSelectAttributeName}')}}" visible="true" stepKey="expandMultiAttr"/>
207194
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.layeredNavigationAttributeOptions('{$grabMultiSelectAttributeName}','option1')}}" stepKey="seeMultiAttrOption1"/>
208195
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.layeredNavigationAttributeOptions('{$grabMultiSelectAttributeName}','option2')}}" stepKey="seeMultiAttrOption2"/>
209196
<conditionalClick selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabDropdownAttributeName}')}}" dependentSelector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabDropdownAttributeName}')}}" visible="true" stepKey="expandDropdownAttr"/>
210197
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.layeredNavigationAttributeOptions('{$grabDropdownAttributeName}','option3')}}" stepKey="seeDropdownAttrOption1"/>
211198
<waitForElementVisible selector="{{StorefrontCategorySidebarSection.layeredNavigationAttributeOptions('{$grabDropdownAttributeName}','option4')}}" stepKey="seeDropdownAttrOption2"/>
212-
213199
<!-- Step 28-29: Update the dropdown product attributes -->
214200
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openDropdownProductAttributeFromSearchResultInGrid">
215201
<argument name="productAttributeCode" value="$$createDropdownProductAttributeWith2Options.attribute_code$$"/>
@@ -219,7 +205,6 @@
219205
</actionGroup>
220206
<selectOption selector="{{AttributePropertiesSection.useInLayeredNavigation}}" userInput="No" stepKey="setDropdownUseInLayeredNavigationAsNo"/>
221207
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveDropdownProductAttributeWith2OptionsPostUpdate"/>
222-
223208
<!-- Step 30: Update the multiSelect product attributes -->
224209
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openMultiSelectProductAttributeFromSearchResultInGrid">
225210
<argument name="productAttributeCode" value="$$createMultiSelectProductAttributeWith2Options.attribute_code$$"/>
@@ -229,7 +214,6 @@
229214
</actionGroup>
230215
<selectOption selector="{{AttributePropertiesSection.useInLayeredNavigation}}" userInput="No" stepKey="setDropdownUseInLayeredNavigationAsNoForMultiSelectAttribute"/>
231216
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveMultiSelectProductAttributeWith2OptionsPostUpdate"/>
232-
233217
<!-- Step 31: Update the text, date, price and YesNo product attributes -->
234218
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openTextProductAttributeFromSearchResultInGrid">
235219
<argument name="productAttributeCode" value="$$createTextProductAttribute.attribute_code$$"/>
@@ -238,39 +222,34 @@
238222
<argument name="usedForSortingInProductListing" value="Yes"/>
239223
</actionGroup>
240224
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveTextProductAttributePostUpdate"/>
241-
242225
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openDateProductAttributeFromSearchResultInGrid">
243226
<argument name="productAttributeCode" value="$$createDateProductAttribute.attribute_code$$"/>
244227
</actionGroup>
245228
<actionGroup ref="AdminUpdateAttributeUsedForSortingInProductListingActionGroup" stepKey="setDateProductUsedForSortingInProductListingAttributeAsYes">
246229
<argument name="usedForSortingInProductListing" value="Yes"/>
247230
</actionGroup>
248231
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveDateProductAttributePostUpdate"/>
249-
250232
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openPriceProductAttributeFromSearchResultInGrid">
251233
<argument name="productAttributeCode" value="$$createPriceProductAttribute.attribute_code$$"/>
252234
</actionGroup>
253235
<actionGroup ref="AdminUpdateAttributeUsedForSortingInProductListingActionGroup" stepKey="setPriceProductUsedForSortingInProductListingAttributeAsYes">
254236
<argument name="usedForSortingInProductListing" value="Yes"/>
255237
</actionGroup>
256238
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="savePriceProductAttributePostUpdate"/>
257-
258239
<actionGroup ref="OpenProductAttributeFromSearchResultInGridActionGroup" stepKey="openYesNoProductAttributeFromSearchResultInGrid">
259240
<argument name="productAttributeCode" value="$$createYesNoProductAttribute.attribute_code$$"/>
260241
</actionGroup>
261242
<actionGroup ref="AdminUpdateAttributeUsedForSortingInProductListingActionGroup" stepKey="setYesNoProductUsedForSortingInProductListingAttributeAsYes">
262243
<argument name="usedForSortingInProductListing" value="Yes"/>
263244
</actionGroup>
264245
<actionGroup ref="SaveProductAttributeActionGroup" stepKey="saveYesNoProductAttributePostUpdate"/>
265-
266246
<!-- Step 32 Clear index and flush cache -->
267247
<actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindexPostUpdatingTheAttribute">
268248
<argument name="indices" value=""/>
269249
</actionGroup>
270250
<actionGroup ref="CliCacheFlushActionGroup" stepKey="cleanCachePostUpdatingTheAttributes">
271251
<argument name="tags" value="config full_page"/>
272252
</actionGroup>
273-
274253
<!-- Step 33-35: Verify the Sort by dropdown options is updated -->
275254
<actionGroup ref="StorefrontNavigateToCategoryUrlActionGroup" stepKey="NavigateToCategoryPageOnStoreFrontPostUpdatingProductAttributes">
276255
<argument name="categoryUrl" value="$$createCategory.custom_attributes[url_key]$$"/>
@@ -281,7 +260,6 @@
281260
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabTextAttributeName}')}}" stepKey="assertTextAttributeNotPresentInLayeredNavigationPostAttributeUpdate"/>
282261
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabDateAttributeName}')}}" stepKey="assertDateAttributeNotPresentInLayeredNavigationPostAttributeUpdate"/>
283262
<waitForElementNotVisible selector="{{StorefrontCategorySidebarSection.expandLayeredNavigationAttribute('{$grabYesNoAttributeName}')}}" stepKey="assertYesNoAttributeNotPresentInLayeredNavigationPostAttributeUpdate"/>
284-
285263
<click selector="{{StorefrontCategoryMainSection.sortedBy}}" stepKey="clickOnSortByDropdownForUpdatedProductAttributesList"/>
286264
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('Position')}}" stepKey="assertPositionOptionInDropdownPostUpdatingProductAttributesList"/>
287265
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('Product Name')}}" stepKey="assertProductNameOptionInDropdownPostUpdatingProductAttributesList"/>
@@ -291,7 +269,6 @@
291269
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('{$grabPriceAttributeName}')}}" stepKey="assertPriceAttributeOptionInDropdownPostUpdatingProductAttributesList"/>
292270
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('{$grabYesNoAttributeName}')}}" stepKey="assertYesNoAttributeOptionInDropdownPostUpdatingProductAttributesList"/>
293271
<waitForElementVisible selector="{{StorefrontCategoryMainSection.sortByDropdownContent('{$grabDropdownAttributeName}')}}" stepKey="assertDropdownAttributeOptionInDropdownPostUpdatingProductAttributesList"/>
294-
295272
<!-- Step 36-40: Verify the Product indexing by Sorting -->
296273
<actionGroup ref="AssertProductSortingBasedOnAttributesInStorefrontCategoryPageActionGroup" stepKey="SortsTheProductsBasedOnTextAttributeFiltersOnStorefront">
297274
<argument name="product1" value="$createSimpleProduct1$"/>

0 commit comments

Comments
 (0)