MAGETWO-95773: Credit memo is created instead of returning error via invoice refund API for Bundle product

- fix unit and static tests

Author: krissyhiserote

app/code/Magento/Sales/Model/Order/Creditmemo/Item/Validation/CreationQuantityValidator.php

@@ -30,6 +30,7 @@ class CreationQuantityValidator implements ValidatorInterface
 
     /**
      * ItemCreationQuantityValidator constructor.
+     *
      * @param OrderItemRepositoryInterface $orderItemRepository
      * @param mixed $context
      */
@@ -65,6 +66,8 @@ public function validate($entity)
     }
 
     /**
+     * Check the quantity to refund is greater than the unrefunded quantity
+     *
      * @param Item $orderItem
      * @param int $qty
      * @return bool
@@ -75,6 +78,8 @@ private function isQtyAvailable(Item $orderItem, $qty)
     }
 
     /**
+     * Check to see if Item is part of the order
+     *
      * @param OrderItemInterface $orderItem
      * @return bool
      */

app/code/Magento/Sales/Model/Order/ItemRepository.php

@@ -95,7 +95,7 @@ public function __construct(
     }
 
     /**
-     * load entity
+     * Load entity
      *
      * @param int $id
      * @return OrderItemInterface
@@ -230,7 +230,7 @@ private function addParentItem(OrderItemInterface $orderItem)
             $orderItem->setParentItem($this->get($parentId));
         } else {
             foreach ($orderItem->getOrder()->getAllItems() as $item) {
-                if($item->getParentItemId() === $orderItem->getItemId()) {
+                if ($item->getParentItemId() === $orderItem->getItemId()) {
                     $item->setParentItem($orderItem);
                 }
             }

app/code/Magento/Sales/Test/Unit/Model/Order/ItemRepositoryTest.php

@@ -156,18 +156,27 @@ public function testGet()
         $productOption = $this->getProductOptionMock();
         $orderItemMock = $this->getOrderMock($productType, $productOption);
 
+        $orderMock = $this->createMock(\Magento\Sales\Model\Order::class);
+        $orderMock->expects($this->once())
+            ->method('getAllItems')
+            ->willReturn([$orderItemMock]);
+
         $orderItemMock->expects($this->once())
             ->method('load')
             ->with($orderItemId)
             ->willReturn($orderItemMock);
-        $orderItemMock->expects($this->once())
+        $orderItemMock->expects($this->exactly(2))
             ->method('getItemId')
             ->willReturn($orderItemId);
+        $orderItemMock->expects($this->once())
+            ->method('getOrder')
+            ->willReturn($orderMock);
 
         $this->metadata->expects($this->once())
             ->method('getNewInstance')
             ->willReturn($orderItemMock);
 
+
         $model = $this->getModel($orderItemMock, $productType);
         $this->assertSame($orderItemMock, $model->get($orderItemId));
 
@@ -213,11 +222,17 @@ public function testDeleteById()
         $orderItemMock = $this->getMockBuilder(\Magento\Sales\Model\Order\Item::class)
             ->disableOriginalConstructor()
             ->getMock();
+
+        $orderMock = $this->createMock(\Magento\Sales\Model\Order::class);
+        $orderMock->expects($this->once())
+            ->method('getAllItems')
+            ->willReturn([$orderItemMock]);
+
         $orderItemMock->expects($this->once())
             ->method('load')
             ->with($orderItemId)
             ->willReturn($orderItemMock);
-        $orderItemMock->expects($this->once())
+        $orderItemMock->expects($this->exactly(2))
             ->method('getItemId')
             ->willReturn($orderItemId);
         $orderItemMock->expects($this->once())
@@ -226,6 +241,9 @@ public function testDeleteById()
         $orderItemMock->expects($this->once())
             ->method('getBuyRequest')
             ->willReturn($requestMock);
+        $orderItemMock->expects($this->once())
+            ->method('getOrder')
+            ->willReturn($orderMock);
 
         $orderItemResourceMock = $this->getMockBuilder(\Magento\Framework\Model\ResourceModel\Db\AbstractDb::class)
             ->disableOriginalConstructor()