Skip to content

Commit d709366

Browse files
author
Valeriy Nayda
committed
MAGETWO-54729: Deliver fixed issues
- Fixes after PR review
1 parent cd14221 commit d709366

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

app/code/Magento/Catalog/Api/CategoryListInterface.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?php
22
/**
3-
*
43
* Copyright © 2016 Magento. All rights reserved.
54
* See COPYING.txt for license details.
65
*/

app/code/Magento/Catalog/Api/Data/CategorySearchResultsInterface.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?php
22
/**
3-
*
43
* Copyright © 2016 Magento. All rights reserved.
54
* See COPYING.txt for license details.
65
*/

app/code/Magento/Catalog/Model/CategoryList.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?php
22
/**
3-
*
43
* Copyright © 2016 Magento. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
7-
86
namespace Magento\Catalog\Model;
97

108
use Magento\Catalog\Api\CategoryListInterface;
@@ -24,22 +22,22 @@ class CategoryList implements CategoryListInterface
2422
/**
2523
* @var CollectionFactory
2624
*/
27-
protected $categoryCollectionFactory;
25+
private $categoryCollectionFactory;
2826

2927
/**
3028
* @var JoinProcessorInterface
3129
*/
32-
protected $extensionAttributesJoinProcessor;
30+
private $extensionAttributesJoinProcessor;
3331

3432
/**
3533
* @var CategorySearchResultsInterfaceFactory
3634
*/
37-
protected $categorySearchResultsFactory;
35+
private $categorySearchResultsFactory;
3836

3937
/**
4038
* @var CategoryRepositoryInterface
4139
*/
42-
protected $categoryRepository;
40+
private $categoryRepository;
4341

4442
/**
4543
* @param CollectionFactory $categoryCollectionFactory
@@ -100,6 +98,8 @@ public function getList(SearchCriteriaInterface $searchCriteria)
10098
}
10199

102100
/**
101+
* Add filter group to collection
102+
*
103103
* @param FilterGroup $filterGroup
104104
* @param Collection $collection
105105
* @return void

app/code/Magento/CatalogWidget/Test/Unit/Model/Rule/Condition/CombineTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ protected function setUp()
3535
->disableOriginalConstructor()
3636
->getMock();
3737
$arguments['conditionFactory'] = $this->conditionFactory;
38+
$arguments['excludedAttributes'] = ['excluded_attribute'];
3839

3940
$this->condition = $objectManagerHelper->getObject(
4041
'Magento\CatalogWidget\Model\Rule\Condition\Combine',
@@ -56,6 +57,7 @@ public function testGetNewChildSelectOptions()
5657
$attributeOptions = [
5758
'sku' => 'SKU',
5859
'category' => 'Category',
60+
'excluded_attribute' => 'Excluded attribute',
5961
];
6062
$productCondition = $this->getMockBuilder('\Magento\CatalogWidget\Model\Rule\Condition\Product')
6163
->setMethods(['loadAttributeOptions', 'getAttributeOption'])

dev/tests/api-functional/testsuite/Magento/Catalog/Api/CategoryListTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?php
22
/**
3-
*
43
* Copyright © 2016 Magento. All rights reserved.
54
* See COPYING.txt for license details.
65
*/

0 commit comments

Comments
 (0)